Upgrade dependencies #109
Merged
Upgrade dependencies #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix errors on MacOS + go 1.18 ``` Error: get command failed: get: 0: getting github.com/bwplotka/bingo@v0.5.2: install: build versioned: # golang.org/x/sys/unix ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.1_13.go:27:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.1_13.go:40:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.go:28:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.go:43:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.go:59:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.go:75:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.go:90:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.go:105:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.go:121:3: //go:linkname must refer to declared function or variable ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201029080932-201ba4db2418/unix/zsyscall_darwin_arm64.go:121:3: too many errors ``` Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
sylr
force-pushed
the
upgrade-dependencies
branch
from
8d8f201 to
3aa706a
Compare
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
sylr
force-pushed
the
upgrade-dependencies
branch
from
bf1b19a to
fb937dd
Compare
|
@bwplotka could you approve the checks ? |
|
Yes, sorry for lag, thanks! |
bwplotka
approved these changes
Apr 7, 2022
|
Thanks for taking care of it. Let's live with that for now, it's silly to really so much on random package that might not be ready for Go1.18 - I only chosen this because it has upper case name 🙃 To fix this: #31 The linter is wrong too, retring. |
|
Merging, for now, I will try fixing linter and test in next PR. |
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors on MacOS + go 1.18
Signed-off-by: Sylvain Rabot sylvain@abstraction.fr