Update to latest specs, add StaticRange and replaceChildren #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwrrp
force-pushed
the
update-to-latest-specs
branch
from
6a01573
to
2328f6a
Compare
bwrrp
force-pushed
the
update-to-latest-specs
branch
from
2328f6a
to
7533783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably not be merged while whatwg/dom#819 is pending, as the changes to adoption in the insertion algorithm seem to have caused a few issues. For now, I've had to add a non-standard
if (previousSibling === node)check ininsertNodeas a work-around to make our tests pass - without thatparent.insertBefore(child, child)would result in an incorrectpreviousSiblingon the mutation record.