Skip to content
This repository was archived by the owner on Mar 25, 2023. It is now read-only.

Commit 5ce7aaa

Browse files
authored
feat(vm-color-picker): Move VM color picker from bar to the VM name line (#583)
* feat(vm-color-picker): Move VM color picker from bar to the VM name line * feat(vm-color-picker): Move VM color picker from bar to the VM name line
1 parent 1ba7538 commit 5ce7aaa

File tree

9 files changed

+35
-22
lines changed

9 files changed

+35
-22
lines changed

src/app/shared/components/color-picker/color-picker.component.html

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,15 @@
33
[class.disabled]="disabled"
44
(click)="handlePreviewClick($event)"
55
>
6-
<div class="color-preview" [style.background-color]="selectedColor?.value"></div>
6+
<div *ngIf="hasColorField"
7+
class="color-preview"
8+
[style.background-color]="selectedColor?.value"></div>
9+
<div *ngIf="!hasColorField"
10+
class="color-preview"
11+
[csPopoverTrigger]="popover"
12+
[style.background-color]="selectedColor?.value"></div>
713
</div>
8-
<md-form-field [csPopoverTrigger]="popover" class="full-width-input">
14+
<md-form-field *ngIf="hasColorField" [csPopoverTrigger]="popover" class="full-width-input">
915
<input
1016
mdInput
1117
[value]="selectedColor?.value.toLowerCase()"
@@ -18,6 +24,7 @@
1824
<cs-popover #popover>
1925
<div
2026
class="color-picker-container mat-elevation-z2"
27+
[ngClass]="{'color-picker-no-field': !hasColorField}"
2128
[style.width.px]="containerWidth"
2229
>
2330
<div

src/app/shared/components/color-picker/color-picker.component.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,8 @@ $input-margin: 10px;
6868
padding: 5px;
6969
box-sizing: content-box;
7070
}
71+
72+
.color-picker-no-field {
73+
margin-left: 47%;
74+
margin-top: 10px;
75+
}

src/app/shared/components/color-picker/color-picker.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export class ColorPickerComponent implements OnChanges, ControlValueAccessor {
3131
@Input() public colors: Array<Color>;
3232
@Input() public colorsPerLine: number;
3333
@Input() public containerWidth = 256;
34+
@Input() public hasColorField = true;
3435
@Output() public change = new EventEmitter();
3536
@ViewChild(PopoverTriggerDirective) public popoverTrigger: PopoverTriggerDirective;
3637
public colorWidth: number;
Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,9 @@
1-
<md-card class="vm-card">
2-
<md-card-header>
3-
<md-card-title>
4-
<h2 class="md-card-title-text">{{ 'VM_PAGE.VM_DETAILS.COLOR' | translate }}</h2>
5-
</md-card-title>
6-
</md-card-header>
7-
<md-card-content>
8-
<cs-color-picker
9-
*ngIf="colorList"
10-
class="color-picker"
11-
[colors]="colorList"
12-
[ngModel]="color"
13-
[disabled]="colorUpdateInProgress"
14-
(change)="changeColor($event)"
15-
></cs-color-picker>
16-
</md-card-content>
17-
</md-card>
1+
<cs-color-picker
2+
*ngIf="colorList"
3+
class="color-picker"
4+
[colors]="colorList"
5+
[ngModel]="color"
6+
[disabled]="colorUpdateInProgress"
7+
[hasColorField]="false"
8+
(change)="changeColor($event)"
9+
></cs-color-picker>

src/app/vm/vm-sidebar/color/vm-color.component.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.color-picker {
2-
margin: -20px 0;
2+
margin-bottom: 14px;
33
width: 330px;
44
}
55

src/app/vm/vm-sidebar/vm-detail/vm-detail.component.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<div *ngIf="vm">
22
<div>
3-
<cs-vm-color [vm]="vm"></cs-vm-color>
43

54
<cs-description
65
[description]="description"

src/app/vm/vm-sidebar/vm-sidebar.component.html

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
<ng-container *ngIf="entity">
22
<div class="title-container">
3-
<h4 class="details-header">{{ entity.displayName }}</h4>
3+
<div class="title-color-container">
4+
<cs-vm-color [vm]="entity"></cs-vm-color>
5+
</div>
6+
<h4 class="details-header ml-1">
7+
{{ entity.displayName }}</h4>
48
<cs-vm-actions-sidebar [vm]="entity"></cs-vm-actions-sidebar>
59
</div>
610
<nav md-tab-nav-bar>

src/app/vm/vm-sidebar/vm-sidebar.component.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,7 @@ h4 {
1717
:host /deep/ .mat-tab-link {
1818
min-width: 83px !important;
1919
}
20+
21+
.title-color-container {
22+
width: 35px;
23+
}

src/app/vm/vm-sidebar/vm-sidebar.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { EntityDoesNotExistError } from '../../shared/components/sidebar/entity-
1414
styleUrls: ['vm-sidebar.component.scss']
1515
})
1616
export class VmSidebarComponent extends SidebarComponent<VirtualMachine> {
17+
1718
constructor(
1819
protected vmService: VmService,
1920
protected notificationService: NotificationService,

0 commit comments

Comments
 (0)