This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
(closes#555) Move VM color picker from bar to the VM name line #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolotyx
suggested changes
Oct 3, 2017
src/style/app.scss
Outdated
| @@ -385,6 +385,10 @@ md-card-actions { | |||
| align-items: center; | |||
| } | |||
|
|
|||
| .title-color-container { | |||
There was a problem hiding this comment.
Please move it to sidebar component
| @@ -14,6 +14,8 @@ import { EntityDoesNotExistError } from '../../shared/components/sidebar/entity- | |||
| styleUrls: ['vm-sidebar.component.scss'] | |||
| }) | |||
| export class VmSidebarComponent extends SidebarComponent<VirtualMachine> { | |||
| public vm: VirtualMachine; | |||
There was a problem hiding this comment.
remove this. Use entity property
| @@ -27,6 +29,7 @@ export class VmSidebarComponent extends SidebarComponent<VirtualMachine> { | |||
| return this.vmService.getWithDetails(id) | |||
| .switchMap(vm => { | |||
| if (vm) { | |||
| this.vm = vm; | |||
There was a problem hiding this comment.
remove this. Use entity property
| @@ -31,6 +31,10 @@ $input-margin: 10px; | |||
| } | |||
| } | |||
|
|
|||
| .color-preview-no-field { | |||
| top: 4px; | |||
There was a problem hiding this comment.
I think that this should be added by some parent component.
add margin instead
zolotyx
suggested changes
Oct 3, 2017
| class="color-preview" | ||
| [style.background-color]="selectedColor?.value"></div> | ||
| <div *ngIf="!hasColorField" | ||
| class="color-preview mb-1" |
HeyRoach
force-pushed
the
555-move-color-picker-to-vm-name-line
branch
from
8c998e2 to
3a9c09e
Compare
HeyRoach
force-pushed
the
555-move-color-picker-to-vm-name-line
branch
from
3a9c09e to
73b57c6
Compare
zolotyx
approved these changes
Oct 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.