Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Grouping isn't saved, Delete buttons are absent, redirect to wrong tab when shared SG rules edit through VM sidebar #1016

Closed
chewlite opened this issue Mar 7, 2018 · 3 comments · Fixed by #1079
Closed

Grouping isn't saved, Delete buttons are absent, redirect to wrong tab when shared SG rules edit through VM sidebar #1016

chewlite opened this issue Mar 7, 2018 · 3 comments · Fixed by #1079
Assignees
@tamazlykar
Labels
bug severity: major statistics bug: regression
Milestone
Release 1.411.21

Comments

@chewlite
Copy link
Collaborator

chewlite commented Mar 7, 2018 •
edited
Loading

Steps

  1. Log in and go to sidebar of VM with shared security group
  2. Open the rule view and select some parameters of grouping
  3. Go to rules edit

Expected result: redirect to Shared SGs tab, there are delete buttons, grouping is saved
Actual result: redirect to Firewall Templates tab, there are no delete buttons, grouping isn't saved
(If Shared SGs tab was opened before going to VMs then redirect will be to this tab)

rules view vm
rules edit vm

Connected Feature ID:
vm_firewall_rules_edit
@chewlite chewlite changed the title Grouping isn't saved and no Delete buttons when firewall rules edit through VM sidebar Grouping isn't saved, Delete buttons are absent and wrong tab is opened when firewall rules edit through VM sidebar Mar 7, 2018
@chewlite chewlite changed the title Grouping isn't saved, Delete buttons are absent and wrong tab is opened when firewall rules edit through VM sidebar Grouping isn't saved, Delete buttons are absent and wrong tab is opened when shared SG rules edit through VM sidebar Mar 7, 2018
@chewlite chewlite changed the title Grouping isn't saved, Delete buttons are absent and wrong tab is opened when shared SG rules edit through VM sidebar Grouping isn't saved, Delete buttons are absent, redirect to wrong tab when shared SG rules edit through VM sidebar Mar 7, 2018
@Nadya913 Nadya913 assigned elenaustyugova and unassigned Nadya913 Mar 7, 2018
@elenaustyugova elenaustyugova added this to the Release 1.410.21 milestone Apr 17, 2018
@elenaustyugova
Copy link
Collaborator

Check that there is no blocking form #1019 (form was refactored)

@tamazlykar tamazlykar self-assigned this May 15, 2018
@tamazlykar tamazlykar mentioned this issue May 15, 2018
Merged
@tamazlykar
Copy link
Collaborator

Test on:
tamazlykar/1016-shared-sg-rules

Regression:
vm_firewall_rules_edit

@tamazlykar tamazlykar assigned Nadya913 and unassigned tamazlykar May 17, 2018
@rennervo rennervo assigned rennervo and unassigned Nadya913 May 17, 2018
@rennervo
Copy link
Collaborator

Tested on tamazlykar/1016-shared-sg-rules

@rennervo rennervo assigned tamazlykar and unassigned rennervo May 17, 2018
tamazlykar added a commit that referenced this issue May 17, 2018
@tamazlykar
fix: add query parameter for redirect to shared SG (#1079)
259ff01 
PR Close #1016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tamazlykar tamazlykar

Labels
bug severity: major statistics bug: regression
Projects
None yet
Milestone
Release 1.411.21
Development

Successfully merging a pull request may close this issue.

fix: add query parameter for redirect to shared SG tamazlykar/cloudstack-ui
7 participants
@dariashka @pm-Egor-Genning @tamazlykar @rennervo @elenaustyugova @chewlite @Nadya913