Get rid of BaseModel for VirtualMachine model

[tamazlykar]

No description provided.

[HeyRoach]

Test:
1180

Check all in:
Virtual machines: VM list, VM details sidebar, VM creation

[chewlite]

VM list

---

1. Start VM - after completion the status "in progress" (yellow), all actions in action box are disabled
Repeated for stop, reinstall, reboot, destroy
Status and actions are correct after the page is refreshed

2. Reset password - following errors
No VM name, no password

3. Filter by zone doesn't work
All VMs in the list was created with zone "Tomsk", but when filter by zone is applied - No results

[chewlite]

VM creation

---

1. Deploy error when VM from template/ISO without tags

2. Error during copying tags when VM from template/ISO with tags

3. Deploy error for VM from template with "password enabled" + with SSH keypair not auto-generated

4. The group isn't assigned to the VM
In the postcreation window "Creating an instance group... OK", but the group is not actually assigned
(this can be seen in details sidebar, in the filter list and when grouping by "group")

[chewlite]

VM details sidebar

---

1. No VM name in details sidebar

2. Assign the group for VM (create new or select existing) - following errors
Error in the console, VMs are duplicated in the list, group isn't assigned

3. Affinity group/SSH key changes are not displayed immediately
When change the affinity group (add/create new/delete) or SSH key we got a notifications about successfull changes, but in the details sidebar nothing has changed. Changes are displayed after the page is refreshed
For example, when we assign any aff.group we see this -

4. Attached ISO isn't displayed immediately
We got a notifications about successfull attachment, but in the details sidebar nothing has changed

5. ISO detachment with errors
Error in the console, VMs are duplicated and empty card in the list

[rennervo]

Lack:2

1) VM in a state "Destroyed" cannot be expunged without refresh page
If you trigger an expunging action for a VM in the "Destroyed" state, then an error will appear and the VM will not disappear from the list. But after updating the page, the VM will not be listed.

Steps:

1. Create new VM
2. Open the action box and select "Destroy"
3. Not checking "Expunge" and confirm dialog
4. Open the action box and select "Expunge"

Actual result: Error appears, VM is not deleted from a list before page update (screenshot)
Expected result: Error not appears, VM disappears from a list after completion of expunge

Feature ID: vm_expunge

Screenshot:

2) VM Group is not saved after page refreshing
If VM is assigned to a group when creating or from sidebar and page is refreshed, then the group is not saved.

Steps 1:

1. Go to create VM
2. Select exist or create a new group
3. Fill to all required fields and create VM
4. Refresh the page and go to the sidebar of the VM

Steps 2:

1. Create new VM without a group
2. Go to the sidebar of the VM
3. Select exist or create a new group for VM
4. Refresh the page

Actual result: Group is not saved for VM, the "Group" area has a value "No group" (screenshot)
Expected result: Group is saved for VM, selected group is in the "Group" area

Feature ID: vm_group_change, vm_creation_vmgroup

Screenshot:

3) SSH key is not added to VM without the page refreshing (This error is from Lack 1)
Error changing SSH key for VM and VM cannot be running when a change to SSH key in VM sidebar. Changes occur only after page refresh.

Steps:

1. Create new VM without SSH key
2. Go to the sidebar of the VM
3. Go to SSH key change
4. Select any SSH key and click "CHANGE"
5. Confirm dialog

Actual result: Error changing SSH key, SSH key is not changed, VM stay in "Starting" state (screenshot)
Expected result: Error disappears, SSH key is changed successful, VM in "Running" state

Feature ID: vm_sshkey_display, vm_sshkey_change

Screenshot:

4) Deploy error for VM from a template with "password enabled" + with SSH keypair not auto-generated (This error is from Lack 1)

Steps:

1. Go to SSH key section and Create new SSH key without auto-generation (example: in a field "Public key" input value "ssh-rsa 12345")
2. Make sure you have a password-enabled template. Otherwise, create it.
3. Go to VM section and click to "Create" button
4. Select a template with a password in the Installation source
5. Select SSH key, that created without auto-generation
6. Fill to all required fields and click to "Create"

Actual result: Error of deploy with a text "Error encrypting password" (screenshot)
Expected result: VM is created successfully

Feature ID: vm_creation_installsource, vm_creation_sshkeypair

Screenshot:

5) Error when open sidebar for Firewall groups and templates

Steps 1:

1. Go to the Firewall section
2. Go to "Firewall templates" tab
3. Click to any Template

Actual result: Sidebar of template opens, but console error with a text "Cannot read property 'find' of undefined" appears (screenshot 1)
Expected result: Sidebar of template opens, console error disappears

Steps 2:

1. Go to the Firewall section
2. Go to "Shared" or "Private" security group tab
3. Click to any firewall group

Actual result: Sidebar of the template not opens, many console errors appear (screenshot 2)
Expected result: Sidebar of template opens, console error disappears

Feature ID: Firewall sidebar

Screenshot 1:

Screenshot 2:

[HeyRoach]

@rennervo
To test only logic (that is you can test in only one browser)

Regression:
image_template_create
volume_create, resize and remove
snapshot_create/remove, volsnapshot_volume_create
account disable, enable
tag create, delete (in vm sidebar, for example)
activitylog_events_display,
sshkey_create

[rennervo]

Lack:3

1) Error №4 from "Lack:2" is repeated

2) VM group is not removed from VM sidebar

Steps 1:

1. Create new VM with group
2. Refresh the page
3. Go to the sidebar of created VM
4. Click to "change group" icon
5. Select "Remove from the group <group_name>"
6. Click to "REMOVE" button

Steps 2:

1. Create new VM without a group
2. Go to the sidebar of created VM
3. Click to "change group" icon
4. Select exist or create new VM group
5. Click to "ASSIGN" button
6. Refresh the page
7. Click to "change group" icon
8. Select "Remove from the group <group_name>"
9. Click to "REMOVE" button

Actual result: Group is not deleted, in the console, an error appears with the text "Cannot read property 'name' of undefined", "Removing an instance group” operation is performed indefinitely in pending dialog. (screenshot)
Expected result: Group is deleted, no console error.

Screenshot:

[rennervo]

Additional: To reproduce the error number 1 of Lack 3, you must leave the checkbox "Start VM" on.

[HeyRoach]

@rennervo
1 - is not our bug (reproduce on master also) it is cloudstack api bug

[Nadya913]

Tested on branch