Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

A tag consisting of spaces can not be deleted or changed #1197

Closed
rennervo opened this issue Aug 10, 2018 · 7 comments
Closed

A tag consisting of spaces can not be deleted or changed #1197

rennervo opened this issue Aug 10, 2018 · 7 comments

Comments

@rennervo
Copy link
Collaborator

Steps to reproduce

  1. Go to VM / Images / Firewall
  2. Click on any entity
  3. Go to tab "Tags"
  4. Create new tag with key = " " and value = " " (space)

Actual result

The created tag can not be deleted or changed

Expected result

The created tag can be deleted or changed

Environment


Browser:
- [ ] Chrome version XX
- [ ] Firefox version XX
- [ ] Safari version XX
- [ ] Opera version XX
- [ ] IE version XX
- [ ] Edge version XX
Others:

Connected feature ID

vm_tag_display
vm_tag_edit
vm_tag_delete

Screenshots

2018-08-10 12-40-16

@tamazlykar
Copy link
Collaborator

@ershovaelena should we allow this tags?
I think this tags should be invalid. What do you think?

@elenaustyugova elenaustyugova added discussion issues to be discussed and removed discussion issues to be discussed labels Aug 17, 2018
@elenaustyugova
Copy link
Collaborator

Discussed with PO: don't let create tags with spaces. Add validation when creating tag.

@HeyRoach
Copy link
Contributor

Test:
vm_tag_create
vm_tag_edit
vm_tag_display
image_tag_display
image_tag_create
image_tag_edit
firewall_tag_display
firewall_tag_create
firewall_tag_edit

@elenaustyugova
Copy link
Collaborator

Need to clarify requirements

@tamazlykar tamazlykar added the discussion issues to be discussed label Aug 21, 2018
@elenaustyugova
Copy link
Collaborator

elenaustyugova commented Aug 22, 2018

Discussed with PO:

The only restriction is no spaces as the first symbol in keys and values. Show error when entering space as the 1st symbol.

So user can enter numbers, spaces inside of keys and values, special symbols.

@elenaustyugova elenaustyugova removed the discussion issues to be discussed label Aug 22, 2018
@rennervo rennervo assigned rennervo and unassigned HeyRoach Aug 28, 2018
@rennervo
Copy link
Collaborator Author

Error entering a space character in the "Value" field is not localized

Steps:

  1. Go to VM/Image/Firewall tags of any entity
  2. Go to create or edit tag
  3. Enter space character in "value" field

Actual result: Error appears with a text "TAGS.TAG_INVALID"
Expected result: Error appears with a text "Field value must start with 'non-space' character"
2018-08-28 14-53-40

@rennervo rennervo assigned HeyRoach and unassigned rennervo Aug 28, 2018
@rennervo
Copy link
Collaborator Author

Tested on 1215

MaslovaEV added a commit to MaslovaEV/cloudstack-ui that referenced this issue Sep 14, 2018
MaslovaEV added a commit to MaslovaEV/cloudstack-ui that referenced this issue Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants