Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

feat(vm-logs): settings #1401

Merged
merged 12 commits into from
Nov 8, 2018
Merged

feat(vm-logs): settings #1401

merged 12 commits into from
Nov 8, 2018

Conversation

wowshakhov
Copy link
Collaborator

No description provided.

Vladimir Shakhov added 8 commits October 30, 2018 14:22
feat(vm-logs): realtime logs (bwsw#1358)
19cc840 
* feat(vm-logs): VM logs plugin (bwsw#1330)

* vm logs mock

* vm logs

* feat(vm-logs): show vm logs

* vm logs

* add tests

* fix action name

* fix selector name

* fix monospace text in column header

* feat(vm-logs): replace show logs icon button with text button

* feat(vm-logs): keyword filtering

* feat(vm-logs): save vm log keywords in query params

* feat(vm-logs): filter by dates

* feat(vm-logs): filter by dates

* v1.10.1

* fix tests

* fix version

* fix package.json

* sort by timestamp

* fix timestamp

* feat(vm-logs): filter vms by account

* refactor date picker label

* refactor labels

* refactor labels

* fix IE

* feat(vm-logs): newest first (bwsw#1346)

* vm logs mock

* vm logs

* feat(vm-logs): show vm logs

* vm logs

* add tests

* fix action name

* fix selector name

* fix monospace text in column header

* feat(vm-logs): replace show logs icon button with text button

* feat(vm-logs): keyword filtering

* feat(vm-logs): save vm log keywords in query params

* feat(vm-logs): filter by dates

* feat(vm-logs): filter by dates

* v1.10.1

* fix tests

* fix version

* fix package.json

* sort by timestamp

* fix timestamp

* feat(vm-logs): filter vms by account

* refactor date picker label

* refactor labels

* refactor labels

* fix IE

* feat(vm-logs): newest first sorting

* add types

* add types

* fix newest first

* fix typings

* fix typings

* fix typings

* feat(vm-logs): log files (bwsw#1351)

* feat(vm-logs): log files

* feat(vm-logs): log files

* code style

* feat(vm-logs): realtime logs

* feat(vm-logs): disable auto update on show logs click

* VM logs (bwsw#1362)

* refactor(vm): get rid of BaseModel for VM model (bwsw#1180)

PR close bwsw#1104

* build(code-coverage): enable source-maps by default (bwsw#1347)

This is a workaround to fix code coverage mapping

* Update README.md

* Create version

* Update README.md

* Update README.md

* feat(navigation): rework navigation menu (bwsw#1333)

PR close bwsw#1235

* feat(config-validation): add config validators (bwsw#1309)

* feat(config-validation): add config validators

* revert security group template interface

* add more validation

* remove allowReorderingSidenav validation, use uniqueItems

* Update vm-colors.scheme.json

* style: update app code style (bwsw#1359)

* Add prettier

* Prettier formatted

* Work in progress

* Fix tsc errors and lint errors

* Ann few more rules and changes to codebase

* Add precommit hook

* Run prettier on entire codebase

* Run prettier

* Fix lint error

* fix bug about grouping

* Fix bugs

* Remove unused files

* fix(misc): semantic errors

* fix(lint)

* Vm logs (bwsw#1363)

* refactor(vm): get rid of BaseModel for VM model (bwsw#1180)

PR close bwsw#1104

* build(code-coverage): enable source-maps by default (bwsw#1347)

This is a workaround to fix code coverage mapping

* Update README.md

* Create version

* Update README.md

* Update README.md

* feat(navigation): rework navigation menu (bwsw#1333)

PR close bwsw#1235

* feat(config-validation): add config validators (bwsw#1309)

* feat(config-validation): add config validators

* revert security group template interface

* add more validation

* remove allowReorderingSidenav validation, use uniqueItems

* Update vm-colors.scheme.json

* style: update app code style (bwsw#1359)

* Add prettier

* Prettier formatted

* Work in progress

* Fix tsc errors and lint errors

* Ann few more rules and changes to codebase

* Add precommit hook

* Run prettier on entire codebase

* Run prettier

* Fix lint error

* fix bug about grouping

* Fix bugs

* Remove unused files

* fix(misc): semantic errors

* fix(lint)

* update to master

* vm logs

* vm logs

* simplify nav menu reducer

* Update virtual-machines-subroutes.ts

* Update accounts-subroutes.ts

* nav menu

* fix current route is not defined

* remove view logs from context menu

* fix event emitter names

* feat(vm-logs): disable date and time pickers in autoupdate mode
feat(vm-logs): replace keywords with search (bwsw#1397)
1198b6f
Merge branch 'vm-logs' of github.com:bwsw/cloudstack-ui into vm-logs
a6e7475
add vm logs settings
3a08c85
feat(vm-logs): scroll (bwsw#1399)
2c1c2a3 
* docs: LogView Plugin description corrected

* fix(config): remove outdated config properties (bwsw#1365)

* feat(vm-logs): scroll

* fix merge conflict

* fix tests

* fix autoscroll refresh

* move selector
use settings values in vm logs
3f18138
feat(vm-logs): real time button position (bwsw#1387)
3b278fc 
* feat(vm-logs): VM logs plugin (bwsw#1330)

* vm logs mock

* vm logs

* feat(vm-logs): show vm logs

* vm logs

* add tests

* fix action name

* fix selector name

* fix monospace text in column header

* feat(vm-logs): replace show logs icon button with text button

* feat(vm-logs): keyword filtering

* feat(vm-logs): save vm log keywords in query params

* feat(vm-logs): filter by dates

* feat(vm-logs): filter by dates

* v1.10.1

* fix tests

* fix version

* fix package.json

* sort by timestamp

* fix timestamp

* feat(vm-logs): filter vms by account

* refactor date picker label

* refactor labels

* refactor labels

* fix IE

* feat(vm-logs): newest first (bwsw#1346)

* vm logs mock

* vm logs

* feat(vm-logs): show vm logs

* vm logs

* add tests

* fix action name

* fix selector name

* fix monospace text in column header

* feat(vm-logs): replace show logs icon button with text button

* feat(vm-logs): keyword filtering

* feat(vm-logs): save vm log keywords in query params

* feat(vm-logs): filter by dates

* feat(vm-logs): filter by dates

* v1.10.1

* fix tests

* fix version

* fix package.json

* sort by timestamp

* fix timestamp

* feat(vm-logs): filter vms by account

* refactor date picker label

* refactor labels

* refactor labels

* fix IE

* feat(vm-logs): newest first sorting

* add types

* add types

* fix newest first

* fix typings

* fix typings

* fix typings

* feat(vm-logs): log files (bwsw#1351)

* feat(vm-logs): log files

* feat(vm-logs): log files

* code style

* feat(vm-logs): realtime logs

* feat(vm-logs): disable auto update on show logs click

* VM logs (bwsw#1362)

* refactor(vm): get rid of BaseModel for VM model (bwsw#1180)

PR close bwsw#1104

* build(code-coverage): enable source-maps by default (bwsw#1347)

This is a workaround to fix code coverage mapping

* Update README.md

* Create version

* Update README.md

* Update README.md

* feat(navigation): rework navigation menu (bwsw#1333)

PR close bwsw#1235

* feat(config-validation): add config validators (bwsw#1309)

* feat(config-validation): add config validators

* revert security group template interface

* add more validation

* remove allowReorderingSidenav validation, use uniqueItems

* Update vm-colors.scheme.json

* style: update app code style (bwsw#1359)

* Add prettier

* Prettier formatted

* Work in progress

* Fix tsc errors and lint errors

* Ann few more rules and changes to codebase

* Add precommit hook

* Run prettier on entire codebase

* Run prettier

* Fix lint error

* fix bug about grouping

* Fix bugs

* Remove unused files

* fix(misc): semantic errors

* fix(lint)

* Vm logs (bwsw#1363)

* refactor(vm): get rid of BaseModel for VM model (bwsw#1180)

PR close bwsw#1104

* build(code-coverage): enable source-maps by default (bwsw#1347)

This is a workaround to fix code coverage mapping

* Update README.md

* Create version

* Update README.md

* Update README.md

* feat(navigation): rework navigation menu (bwsw#1333)

PR close bwsw#1235

* feat(config-validation): add config validators (bwsw#1309)

* feat(config-validation): add config validators

* revert security group template interface

* add more validation

* remove allowReorderingSidenav validation, use uniqueItems

* Update vm-colors.scheme.json

* style: update app code style (bwsw#1359)

* Add prettier

* Prettier formatted

* Work in progress

* Fix tsc errors and lint errors

* Ann few more rules and changes to codebase

* Add precommit hook

* Run prettier on entire codebase

* Run prettier

* Fix lint error

* fix bug about grouping

* Fix bugs

* Remove unused files

* fix(misc): semantic errors

* fix(lint)

* update to master

* vm logs

* vm logs

* simplify nav menu reducer

* Update virtual-machines-subroutes.ts

* Update accounts-subroutes.ts

* nav menu

* fix current route is not defined

* remove view logs from context menu

* fix event emitter names

* feat(vm-logs): real time button position

* remove unused import

* add resize observer polyfill
Merge branch 'master' of github.com:bwsw/cloudstack-ui into 1377-vm-l…
e83023b 
…ogs-settings
@coveralls
Copy link

coveralls commented Nov 2, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1306

  • 40 of 67 (59.7%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 53.716%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/root-store/server-data/user-tags/user-tags.selectors.ts 2 7 28.57%
src/app/root-store/server-data/user-tags/user-tags.effects.ts 2 12 16.67%
src/app/root-store/server-data/user-tags/user-tags.actions.ts 18 30 60.0%
Totals Coverage Status
Change from base Build 1300: 0.04%
Covered Lines: 8176
Relevant Lines: 13385
💛 - Coveralls

@wowshakhov wowshakhov requested a review from tamazlykar November 6, 2018 04:40
tamazlykar
tamazlykar suggested changes Nov 6, 2018
View reviewed changes
src/app/root-store/server-data/user-tags/user-tags.actions.ts Outdated Show resolved Hide resolved
src/app/root-store/server-data/user-tags/user-tags.actions.ts Outdated Show resolved Hide resolved
src/app/root-store/server-data/user-tags/user-tags.selectors.ts Show resolved Hide resolved
src/app/root-store/server-data/user-tags/user-tags.state.ts Outdated Show resolved Hide resolved
src/app/settings/selectors/settings.selectors.ts
@@ -3,6 +3,15 @@ import { createSelector } from '@ngrx/store';
import { SettingsViewModel } from '../view-models';
import * as userTags from '../../root-store/server-data/user-tags/user-tags.selectors';

const getVmLogsSettings = createSelector(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you decide to create a new selector for this instead of simply put same string in selector below?

src/app/settings/components/vm-logs-settings/vm-logs-minutes/vm-logs-minutes.component.html
<button
mat-button
[disabled]="minutes == +minutesField.value"
(click)="minutesChanged.emit(+minutesField.value)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update type assertions according to the style guide

src/app/settings/components/vm-logs-settings/vm-logs-messages/vm-logs-messages.component.html
<button
mat-button
[disabled]="messages == +messagesField.value"
(click)="messagesChanged.emit(+messagesField.value)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update type assertions according to the style guide

src/app/settings/settings.module.ts Outdated
@@ -1,10 +1,8 @@
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { ClipboardModule, ClipboardService } from 'ngx-clipboard';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to separate third party imports and local imports. This described in Angular Style Guide

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add optimize imports sort by module

src/app/settings/settings.module.ts Outdated Show resolved Hide resolved
src/app/vm-logs/redux/vm-logs.effects.ts
switchMap(() =>
timer(0, 10000).pipe(
withLatestFrom(this.store.pipe(select(UserTagsSelectors.getVmLogsShowLastMinutes))),
switchMap(([_, minutes]) =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use implicit name instead of _

@wowshakhov wowshakhov merged commit 0d5e805 into bwsw:master Nov 8, 2018
@wowshakhov wowshakhov deleted the 1377-vm-logs-settings branch November 8, 2018 05:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tamazlykar tamazlykar tamazlykar approved these changes

Assignees

@Nadya913 Nadya913

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wowshakhov @coveralls @tamazlykar @Nadya913