Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Add billing hook notifications to UI #1602

Closed
elenaustyugova opened this issue Feb 22, 2019 · 11 comments
Closed

Add billing hook notifications to UI #1602

elenaustyugova opened this issue Feb 22, 2019 · 11 comments
Assignees
@dron8552
Labels
enhancement
Milestone
Release 1.411.29

Comments

@elenaustyugova
Copy link
Collaborator

Description

User should be able to see readable error messages/notifications when updating resources

This issue covers the following requirements:

REQ_RSC_001
@elenaustyugova elenaustyugova added this to the Release 1.411.29 milestone Feb 22, 2019
@elenaustyugova elenaustyugova changed the title Add billing hook errors localization for UI Add billing hook notifications (errors/success) localization for UI Feb 22, 2019
dron8552 added a commit to dron8552/cloudstack-ui that referenced this issue Feb 22, 2019
@dron8552
fix(resource-limits-plugin): add billing hook translations (bwsw#1602)
b77ec84
@elenaustyugova
Copy link
Collaborator Author

To test: 3 test cases mentioned in Requirements 1.411.29 doc

dron8552 added a commit to dron8552/cloudstack-ui that referenced this issue Feb 25, 2019
@dron8552
fix(resource-limits-plugin): add internal errors translations (bwsw#1602
f67d0e8 
)
@dron8552
Copy link
Collaborator

Test on PR using Netpoint users with domains.

@dron8552 dron8552 assigned Nadya913 and unassigned dron8552 Feb 26, 2019
@dron8552 dron8552 mentioned this issue Feb 27, 2019
Closed
dron8552 added a commit to dron8552/cloudstack-ui that referenced this issue Feb 28, 2019
@dron8552
fix(resource-limits-plugin): remove billing hook translations (bwsw#1602
398480f 
)
dron8552 added a commit to dron8552/cloudstack-ui that referenced this issue Feb 28, 2019
@dron8552
fix(resource-limits-plugin): added internal error translation (bwsw#1602
9b31cd0 
)
@Nadya913
Copy link
Collaborator

Nadya913 commented Feb 28, 2019 •
edited by elenaustyugova
Loading

@bwsw Ivan, we have 3 cases to discuss:

  1. Error text contains not requested amount resources (DATABOX).
  • Case RAM: The current amount limit of Ram is 4 GB and min quota is 2 GB. According to the error was requested 6 GB, but it wasn't - please see the video.
    Expected: 4 GB
    peek 2019-02-28 16-15
  • Case Primary:
    The current amount limit of Primary is 1100 GB and min quota is 1000 GB. According to the error was requested 1000 GB, but it wasn't - please see the video.
    Expected: 1100 GB
    peek 2019-02-28 16-26
  1. Calculated balance from billing appear as not currency value: The requested resources RAM: 11 GB, Primary Storage: 100 GB, Secondary Storage: 1542 GB cannot be provided. Automatic allocation requires that the account balance is not less than 1349.6000000000001 Rub., current balance is 762.18 Rub. / Запрошенные ресурсы ОЗУ: 117 ГБ, Основное хранилище: 70 ГБ, Дополнительное хранилище: 276 GB не могут быть предоставлены. Для автоматического выделения требуется чтобы баланс счета был не менее чем 5670.490000000001 Руб., сейчас 761.11 Руб.

@elenaustyugova elenaustyugova changed the title Add billing hook notifications (errors/success) localization for UI Add billing hook notifications to UI Feb 28, 2019
@elenaustyugova elenaustyugova assigned dron8552 and unassigned Nadya913 Mar 1, 2019
@elenaustyugova
Copy link
Collaborator Author

@Nadya913 2nd fail is fixed by Ivan

dron8552 added a commit to dron8552/cloudstack-ui that referenced this issue Mar 1, 2019
@dron8552
fix(resource-limits-plugin): use one request to update quotas and lim…
bdfd7d0 
…its (bwsw#1602)
@dron8552 dron8552 assigned Nadya913 and unassigned dron8552 Mar 1, 2019
@dron8552
Copy link
Collaborator

dron8552 commented Mar 1, 2019

Fixed multiple requests when updated resources by the user and admin (send all changed resources in one request).

@elenaustyugova
Copy link
Collaborator Author

@Nadya913 also please test

  • main cases for admin (changing quotas)
  • main cases for user (requesting resources)

dron8552 added a commit to dron8552/cloudstack-ui that referenced this issue Mar 4, 2019
@dron8552
fix(resource-limits-plugin): fixed zero values saving for resource qu…
954bda7 
…otas (bwsw#1602)
@Nadya913
Copy link
Collaborator

Nadya913 commented Mar 4, 2019 •
edited
Loading

  1. The setting quota is broken for zero value both for min and max. The quota parameter isn't sent in this case.
    http://cs-ui-ci.bitworks.software:8888/1604/client/api?command=gatewayApi&cmd=updateResourceLimits&maximum2=15&realm=resource-limits&env=cs2-development&response=json&sessionKey=wdyv_ViP9_DoYg-46KMpx1FDvzU
    Expected: The quota parameter with zero value is sent.
    zero
  2. 5 digit number is cut in value slider. This is a master bug, but would you please fix it if possible here.
    5digit
  3. @bwsw The current amount limit of Primary is 1100 GB and min quota is 1000 GB in databox domain. According to the error was requested 1000 GB, but it wasn't - please see the video.
    Expected: 1100 GB in text error should appear
    testprimary

dron8552 added a commit to dron8552/cloudstack-ui that referenced this issue Mar 4, 2019
@dron8552
fix(resource-limits-plugin): fixed mat-slider-thumb size to show 2000…
3ef43a6 
…0 value (bwsw#1602)
@dron8552
Copy link
Collaborator

dron8552 commented Mar 4, 2019

Fixed except the third point.

@Nadya913
Copy link
Collaborator

Nadya913 commented Mar 4, 2019 •
edited
Loading

The first and second issues are fixed. Waiting for feedback for third issue.

@elenaustyugova
Copy link
Collaborator Author

@Nadya913 third issue was fixed by Ivan. let's check it and if there are no other cases for regression - please resolve the issue

@Nadya913
Copy link
Collaborator

Nadya913 commented Mar 5, 2019 •
edited
Loading

  1. Request resource button isn't aligned with free/user switcher in Firefox.
    requestbutton

dron8552 added a commit to dron8552/cloudstack-ui that referenced this issue Mar 5, 2019
@dron8552
fix(resource-limits-plugin): fixed request resources button alignment…
6d02327 
… in firefox (bwsw#1602)
@Nadya913 Nadya913 assigned dron8552 and unassigned Nadya913 Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dron8552 dron8552

Labels
enhancement
Projects
None yet
Milestone
Release 1.411.29
Development

No branches or pull requests
3 participants
@elenaustyugova @Nadya913 @dron8552