Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Add additional fields to SO chooser component in VM creation #859

Closed
elenaustyugova opened this issue Dec 29, 2017 · 5 comments
Closed

Add additional fields to SO chooser component in VM creation #859

elenaustyugova opened this issue Dec 29, 2017 · 5 comments

Comments

@elenaustyugova
Copy link
Collaborator

elenaustyugova commented Dec 29, 2017

This issue is a continuation of #502

Acceptance criteria

  1. Characteristics should be separated in "main" (основные) - was done in Change service offering chooser component in VM creation and VM details sidebar (main characteristics) #502 and additional (дополнительные)
  2. A table should contain main characteristics of each service offering. Additional characteristics should open only when needed
  • Main characteristics:
    -- CPU Cores (Ядра CPU)
    -- CPU (MHz) (CPU (МГц))
    -- Memory (Память (МБ))
    -- Network Rate (Mb/s) (скорость сети)
    - Additional characteristics: all the rest from original CS interface
  1. A button "Show additional fields" ("Дополнительные характеристики") should be placed above cancel and save(change)
  2. If the button is clicked - additional columns should appear on the right side, user can see it by scrolling
  3. Document this feature in Custom features local document

Pay attention to units of measure! (not KB, but MB etc)

Connected feature ID:

  • vm_creation_so
  • vm_creation_so_custom
  • vm_SO_display
  • vm_SO_change
@elenaustyugova elenaustyugova changed the title Add additional fields to Service Offering chooser component in VM creation Add additional fields to Service Offering chooser component in VM creation (main characteristics) Dec 29, 2017
@elenaustyugova elenaustyugova changed the title Add additional fields to Service Offering chooser component in VM creation (main characteristics) Add additional fields to Service Offering chooser component in VM creation Jan 15, 2018
@bwsw bwsw added this to the 1.410.19 milestone Jan 15, 2018
@elenaustyugova elenaustyugova changed the title Add additional fields to Service Offering chooser component in VM creation Add additional fields to SO chooser component in VM creation Jan 19, 2018
@ksendart ksendart self-assigned this Jan 22, 2018
ksendart added a commit to ksendart/cloudstack-ui that referenced this issue Jan 23, 2018
ksendart added a commit to ksendart/cloudstack-ui that referenced this issue Jan 23, 2018
@ksendart
Copy link
Contributor

test on: http://cs-ui-ci.z1.netpoint-dc.com:8080/ksendart/859-so-additional-fields
to test:
vm_creation_so
vm_creation_so_custom
vm_SO_display

ksendart added a commit to ksendart/cloudstack-ui that referenced this issue Jan 23, 2018
ksendart added a commit to ksendart/cloudstack-ui that referenced this issue Jan 24, 2018
@elenaustyugova elenaustyugova assigned Nadya913 and unassigned ksendart Jan 31, 2018
@Nadya913 Nadya913 assigned rennervo and unassigned Nadya913 Feb 1, 2018
ksendart added a commit to ksendart/cloudstack-ui that referenced this issue Feb 6, 2018
@ksendart
Copy link
Contributor

ksendart commented Feb 6, 2018

@ksendart ksendart closed this as completed Feb 6, 2018
@ksendart ksendart reopened this Feb 6, 2018
@rennervo
Copy link
Collaborator

rennervo commented Feb 6, 2018

Errors:

  1. Fields of custom SO parameters allow input any characters in browsers FF (ver. 58.0.1 64bit), MS Edge (ver. 41.16299.15.0) and MS IE (ver. 11.192.16299.0)
    Expected result: These fields allow input only numeric characters.
    cso values

  2. SO doesn't change in browser MS IE (ver. 11.192.16299.0) when editing from sidebar VM.

@rennervo rennervo assigned ksendart and unassigned rennervo Feb 6, 2018
ksendart added a commit to ksendart/cloudstack-ui that referenced this issue Feb 7, 2018
@ksendart
Copy link
Contributor

ksendart commented Feb 7, 2018

@rennervo

  1. IE, MS Edge, and FF do not support input type=number correctly, that is why you do not see arrows and are able to insert characters into fields. But form provides validation, and if you insert characters, the submit button is disabled (see attached video). I suppose that this type of validation and this kind of form behavior are suitable.
  2. I so sorry, but I could not reproduce the second point. I attached the video. All operations performed correctly in MS IE.
    vm-change-so 1

@elenaustyugova elenaustyugova assigned Nadya913 and unassigned ksendart Feb 7, 2018
@Nadya913 Nadya913 assigned rennervo and unassigned Nadya913 Feb 7, 2018
@rennervo
Copy link
Collaborator

rennervo commented Feb 7, 2018

@ksendart
Tested on ksendart/859-so-additional-fields

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants