This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
feat: cross-browser validation of values in a numeric input field #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolotyx
reviewed
May 18, 2018
package.json
Outdated
| @@ -50,6 +50,7 @@ | |||
| "rxjs": "^5.5.2", | |||
| "showdown": "^1.8.4", | |||
| "sprintf-js": "^1.1.1", | |||
| "typescript-debounce-decorator": "^0.0.17", | |||
vanekbr
approved these changes
May 27, 2018
zolotyx
reviewed
May 29, 2018
| return this.updateElementValue(newValue); | ||
| } | ||
|
|
||
| const value: number = +newValue; |
There was a problem hiding this comment.
newValue is a number, but you convert it to number anyway, could you please add a correct typing for the method arguments
tamazlykar
force-pushed
the
940-input-number-validation
branch
from
fe82561 to
948ff4f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940
The implemented directive used to prevent user to the entry of the text values into the numeric input field and to limit the possibility of entering numbers beyond the boundaries settled by "csMaxValue" and "csMinValue".
Problem was that it wasn't validated by some browsers like IE.
Also, there is a new requirement for number inputs that have some valid ranges.