This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
feat: keep sidenav visibility state on the server for every user #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolotyx
reviewed
Aug 13, 2018
| public toggleDrawer(): void { | ||
| this.layoutService.toggleDrawer(); | ||
| public closeSidenav(): void { | ||
| this.store.dispatch(new layoutActions.CloseSidenav); |
zolotyx
reviewed
Aug 13, 2018
src/app/home/home.component.ts
Outdated
| @@ -16,10 +15,10 @@ import * as serviceOfferingActions from '../reducers/service-offerings/redux/ser | |||
| }) | |||
| export class HomeComponent extends WithUnsubscribe() implements OnInit { | |||
| public disableSecurityGroups = false; | |||
| public showSidenav$ = this.store.select(layoutSelectors.getIsShowSidenav); | |||
There was a problem hiding this comment.
why do you use this language?
"is show sidenav" why not to use" "is sidenav visible"
zolotyx
reviewed
Aug 13, 2018
|
Changes added |
zolotyx
approved these changes
Aug 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #944
We omit the result of setting the tag value representing sidenav status on the server.
This is required so that the UI reacts instantly and does not wait until an answer comes from the server.
Downsides: if the tag is not set, the user selected state will not be saved (this can happen very rarely)