Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

fix(ssh-keys-sidebar): SSH keys sidebar loads invalid key if there ar… #653

Merged
merged 4 commits into from
Nov 13, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/shared/services/ssh-keypair.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ export class SSHKeyPairService extends BaseBackendCachedService<SSHKeyPair> {
super(http);
}

public getByName(name: string): Observable<SSHKeyPair> {
return this.getList({ name }).map(sshKeys => sshKeys[0]);
public getByParams(params): Observable<SSHKeyPair> {
return this.getList(params).map(sshKeys => sshKeys[0]);
}

public create(params: SshKeyCreationData): Observable<SSHKeyPair> {
Expand Down
2 changes: 1 addition & 1 deletion src/app/ssh-keys/ssh-key-list/ssh-key-list.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class SshKeyListComponent {
public selectSshKeyPair(sshKeyPair: SSHKeyPair): void {
this.router.navigate(['view', sshKeyPair.name], {
relativeTo: this.route,
queryParamsHandling: 'preserve'
queryParams: {account: sshKeyPair.account}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add queryParamsHandling: 'preserve'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if queryParams and queryParamsHandling: 'preserve' are used together, the query parameters are not adding to the routerLink

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeyRoach , is there any other way to pass params to route with queryParamsHandling: 'preserve'?

});
}

Expand Down
55 changes: 30 additions & 25 deletions src/app/ssh-keys/ssh-key-sidebar/ssh-key-sidebar.component.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, OnInit } from '@angular/core';
import { Component } from '@angular/core';
import { ActivatedRoute, Router } from '@angular/router';
import { Observable } from 'rxjs/Observable';
import { SidebarComponent } from '../../shared/components/sidebar/sidebar.component';
Expand All @@ -13,16 +13,14 @@ import { EntityDoesNotExistError } from '../../shared/components/sidebar/entity-
selector: 'cs-ssh-key-sidebar',
templateUrl: 'ssh-key-sidebar.component.html'
})
export class SshKeySidebarComponent extends SidebarComponent<SSHKeyPair> implements OnInit {
export class SshKeySidebarComponent extends SidebarComponent<SSHKeyPair> {
public description: string;

constructor(
protected entityService: SSHKeyPairService,
protected notificationService: NotificationService,
protected route: ActivatedRoute,
protected router: Router,
protected userTagService: UserTagService
) {
constructor(protected entityService: SSHKeyPairService,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use correct styling for constructor

protected notificationService: NotificationService,
protected route: ActivatedRoute,
protected router: Router,
protected userTagService: UserTagService) {
super(entityService, notificationService, route, router);
}

Expand All @@ -32,23 +30,30 @@ export class SshKeySidebarComponent extends SidebarComponent<SSHKeyPair> impleme
}

protected loadEntity(name: string): Observable<SSHKeyPair> {
return this.entityService.getByName(name)
.switchMap(sshKeyPair => {
if (sshKeyPair) {
return Observable.of(sshKeyPair);
} else {
return Observable.throw(new EntityDoesNotExistError());
return this.route.queryParams
.switchMap(value => {
const params = { name };
if (value.account) {
params['account'] = value.account;
}
})
.switchMap(sshKeyPair => {
return Observable.forkJoin(
Observable.of(sshKeyPair),
this.userTagService.getSshKeyDescription(sshKeyPair)
);
})
.map(([sshKeyPair, description]) => {
this.description = description;
return sshKeyPair;
return this.entityService.getByParams(params)
.switchMap(sshKeyPair => {
if (sshKeyPair) {
return Observable.of(sshKeyPair);
} else {
return Observable.throw(new EntityDoesNotExistError());
}
})
.switchMap(sshKeyPair => {
return Observable.forkJoin(
Observable.of(sshKeyPair),
this.userTagService.getSshKeyDescription(sshKeyPair)
);
})
.map(([sshKeyPair, description]) => {
this.description = description;
return sshKeyPair;
});
});
}
}