This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
fix(ssh-keys-sidebar): SSH keys sidebar loads invalid key if there ar… #653
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f415290
fix(ssh-keys-sidebar): SSH keys sidebar loads invalid key if there ar…
HeyRoach 97df1d4
fix(ssh-keys-sidebar): SSH keys sidebar loads invalid key if there ar…
HeyRoach 9110eec
fix(ssh-keys-sidebar): SSH keys sidebar loads invalid key if there ar…
HeyRoach 213f91c
fix(ssh-keys-sidebar): SSH keys sidebar loads invalid key if there ar…
HeyRoach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { Component, OnInit } from '@angular/core'; | ||
import { Component } from '@angular/core'; | ||
import { ActivatedRoute, Router } from '@angular/router'; | ||
import { Observable } from 'rxjs/Observable'; | ||
import { SidebarComponent } from '../../shared/components/sidebar/sidebar.component'; | ||
|
@@ -13,16 +13,14 @@ import { EntityDoesNotExistError } from '../../shared/components/sidebar/entity- | |
selector: 'cs-ssh-key-sidebar', | ||
templateUrl: 'ssh-key-sidebar.component.html' | ||
}) | ||
export class SshKeySidebarComponent extends SidebarComponent<SSHKeyPair> implements OnInit { | ||
export class SshKeySidebarComponent extends SidebarComponent<SSHKeyPair> { | ||
public description: string; | ||
|
||
constructor( | ||
protected entityService: SSHKeyPairService, | ||
protected notificationService: NotificationService, | ||
protected route: ActivatedRoute, | ||
protected router: Router, | ||
protected userTagService: UserTagService | ||
) { | ||
constructor(protected entityService: SSHKeyPairService, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use correct styling for constructor |
||
protected notificationService: NotificationService, | ||
protected route: ActivatedRoute, | ||
protected router: Router, | ||
protected userTagService: UserTagService) { | ||
super(entityService, notificationService, route, router); | ||
} | ||
|
||
|
@@ -32,23 +30,30 @@ export class SshKeySidebarComponent extends SidebarComponent<SSHKeyPair> impleme | |
} | ||
|
||
protected loadEntity(name: string): Observable<SSHKeyPair> { | ||
return this.entityService.getByName(name) | ||
.switchMap(sshKeyPair => { | ||
if (sshKeyPair) { | ||
return Observable.of(sshKeyPair); | ||
} else { | ||
return Observable.throw(new EntityDoesNotExistError()); | ||
return this.route.queryParams | ||
.switchMap(value => { | ||
const params = { name }; | ||
if (value.account) { | ||
params['account'] = value.account; | ||
} | ||
}) | ||
.switchMap(sshKeyPair => { | ||
return Observable.forkJoin( | ||
Observable.of(sshKeyPair), | ||
this.userTagService.getSshKeyDescription(sshKeyPair) | ||
); | ||
}) | ||
.map(([sshKeyPair, description]) => { | ||
this.description = description; | ||
return sshKeyPair; | ||
return this.entityService.getByParams(params) | ||
.switchMap(sshKeyPair => { | ||
if (sshKeyPair) { | ||
return Observable.of(sshKeyPair); | ||
} else { | ||
return Observable.throw(new EntityDoesNotExistError()); | ||
} | ||
}) | ||
.switchMap(sshKeyPair => { | ||
return Observable.forkJoin( | ||
Observable.of(sshKeyPair), | ||
this.userTagService.getSshKeyDescription(sshKeyPair) | ||
); | ||
}) | ||
.map(([sshKeyPair, description]) => { | ||
this.description = description; | ||
return sshKeyPair; | ||
}); | ||
}); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add queryParamsHandling: 'preserve'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if queryParams and queryParamsHandling: 'preserve' are used together, the query parameters are not adding to the routerLink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeyRoach , is there any other way to pass params to route with queryParamsHandling: 'preserve'?