This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
fix(so-classes): Store SO classes in config.json #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariashka
approved these changes
Feb 5, 2018
zolotyx
suggested changes
Feb 7, 2018
| @@ -47,7 +47,7 @@ export class AccountTagService implements EntityTagService { | |||
| return `${this.keys.sshDescription}.${sshKey.fingerprint}`; | |||
| } | |||
|
|
|||
| public writeTag(key: string, value: string): Observable<string> { | |||
| public writeTag(key: string, value: string): Observable<any> { | |||
There was a problem hiding this comment.
@zolotyx I replaced string with any, because TagService.writeTag returns TagService.update(entity: any, entityName: string, key: string, value: any): Observable<any>. This method is normally used in different methods, which return Observables of different objects, not only strings.
There was a problem hiding this comment.
@ksendart , but tag service always returns string values of the tag. Or not? Can we change TagService.update signature?
There was a problem hiding this comment.
@zolotyx TagService.update accept entity: any returns newEntity - object with new tags attribute.
zolotyx
approved these changes
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#950