This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
feat: Adds Slice length tag #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 95.71% 95.44% -0.27%
==========================================
Files 11 11
Lines 1236 1251 +15
==========================================
+ Hits 1183 1194 +11
- Misses 30 32 +2
- Partials 23 25 +2
Continue to review full report at Codecov.
|
bxcodec
reviewed
Jun 12, 2020
| @@ -108,6 +108,7 @@ const ( | |||
| AmountWithCurrencyTag = "amount_with_currency" | |||
| SKIP = "-" | |||
| Length = "len" | |||
| SliceLength = "slice_len" | |||
There was a problem hiding this comment.
is it possible to use len instead? to make the same experience?
There was a problem hiding this comment.
Shouldn't it be possible to use both?
Have a slice of []string where you can set both the length of the slice and of each string in the slice?
bxcodec
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility to set a specific slice length for all types of slices.
Tag:
slice_len=$dwith $d a number >= 0Fixes #92