removes Adolf from male names

[DavidLarsKetch]

Sure it's a name... but... not really a name that needs to be included.

For what it's worth, my use case is I use these names for creating easier to remember referral codes.

[codecov]

Codecov Report

Merging #128 (0ed7de5) into master (b0be786) will decrease coverage by 1.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   93.65%   92.31%   -1.35%     
==========================================
  Files          11       11              
  Lines        1309     1080     -229     
==========================================
- Hits         1226      997     -229     
  Misses         45       45              
  Partials       38       38              

Impacted Files	Coverage Δ
person.go	100.00% <ø> (ø)
internet.go	76.69% <0.00%> (-5.53%)	⬇️
uuid.go	82.35% <0.00%> (-3.37%)	⬇️
datetime.go	97.46% <0.00%> (-0.80%)	⬇️
faker.go	90.53% <0.00%> (-0.79%)	⬇️
lorem.go	100.00% <0.00%> (ø)
phone.go	100.00% <0.00%> (ø)
price.go	100.00% <0.00%> (ø)
address.go	100.00% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0be786...0ed7de5. Read the comment docs.

[bxcodec]

Hi @DavidLarsKetch ,

Thanks for the PR and thanks for using faker.
Is there any more concrete case or general use-case, why we need to remove this? I believe this shouldn't be a problem at all.

I'm afraid I can't approve of this 🙏

[DavidLarsKetch]

Hey @bxcodec, yeah, the use case is pretty straightforward for me. We use the first names and years to create referral codes our end users can share with one another to get discounts. A referral code using the specific spelling Adolf has negative associations with Adolf Hitler. So, far as I know, that spelling has since fallen out of disfavor.

[bxcodec]

Gotcha, it's not a big deal for some people, but since it's a bit sensitive to some people, I'll approve this. Will released in the next version.

For now, you can use the master version.