Added IPAddress.h SPI.h , WCharacter.h, sqrt and delayMicroseconds #18
Conversation
There was a problem hiding this comment.
Hi, thanks, this is great. I like how you fixed some style issues for consistency, e.g. trailing white spaces and changing boolean to bool.
A few requests before I merge this:
- Can you rebase your PR onto the latest commit on the
developbranch? There should be no conflicts with anything that I committed since you branched. - Can you update the copyright note at the top to add your name, and a few lines to note that you changed a few things?
- An incorrect function signature on
delayMicroseconds(), I'll point that out in the review.
Arduino.cpp
Outdated
| @@ -21,6 +21,10 @@ | |||
| // Arduino methods emulated in Unix | |||
| // ----------------------------------------------------------------------- | |||
|
|
|||
| void delayMicroseconds(unsigned long us) { | |||
There was a problem hiding this comment.
This should be
void delayMicroSeconds(unsigned int us)to be compatible with other cores.
Arduino.h
Outdated
| @@ -81,6 +82,7 @@ | |||
|
|
|||
| extern "C" { | |||
|
|
|||
| void delayMicroseconds(unsigned long us); | |||
There was a problem hiding this comment.
ditto, change unsigned long to unsigned int
| /* | ||
| IPAddress.cpp - Base class that provides IPAddress | ||
| Copyright (c) 2011 Adrian McEwen. All right reserved. | ||
|
|
There was a problem hiding this comment.
Add something like:
Copied from Arduino AVR core 1.8.3 by Erik Tideman. Removed
unnecessary 'friend' declarations.
| * Copyright (c) 2014 by Paul Stoffregen <paul@pjrc.com> (Transaction API) | ||
| * Copyright (c) 2014 by Matthijs Kooijman <matthijs@stdin.nl> (SPISettings AVR) | ||
| * Copyright (c) 2014 by Andrew J. Kroll <xxxajk@gmail.com> (atomicity fixes) | ||
| * SPI Master library for arduino. |
There was a problem hiding this comment.
Add something like:
Copyright (c) 2021 by Erik Tideman (Replaced actual implementations with stubs.)
| * Copyright (c) 2014 by Paul Stoffregen <paul@pjrc.com> (Transaction API) | ||
| * Copyright (c) 2014 by Matthijs Kooijman <matthijs@stdin.nl> (SPISettings AVR) | ||
| * Copyright (c) 2014 by Andrew J. Kroll <xxxajk@gmail.com> (atomicity fixes) | ||
| * SPI Master library for arduino. |
There was a problem hiding this comment.
Add something like:
Copyright (c) 2021 by Erik Tideman (Replaced actual implementations with stubs.)
| /* | ||
| WCharacter.h - Character utility functions for Wiring & Arduino | ||
| Copyright (c) 2010 Hernando Barragan. All right reserved. | ||
|
|
There was a problem hiding this comment.
Add something like:
Copyright (c) 2021 by Erik Tideman (Replaced 'boolean' with 'bool')
… including Arduino.h Same behavior as arduino
|
Hi again, Thanks for great work! |
|
This looks great, thanks for sending the PR. |
…ementation of transfer() (see #18)
…Arduino features, added in #18
Hi,
I'm using your linux port as a drop in replacement of the official Arduino core when compiling unit tests. I ran across some missing functions and added those that gave me compiler errors. Most is just copy and paste from the official core!