Added tone() and noTone() stubs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxparks
reviewed
Aug 4, 2022
cores/epoxy/Arduino.cpp
Outdated
| @@ -65,6 +65,16 @@ unsigned long micros() { | |||
| return us; | |||
| } | |||
|
|
|||
| void tone(uint8_t _pin, unsigned int frequency, unsigned long duration) | |||
There was a problem hiding this comment.
nit: change this to
void tone(uint8_t /*_pin*/, unsigned int /*frequency*/, unsigned long /*duration*/) {}because
- The compiler will warn about unused variables otherwise.
- Curly brace on previous line, for consistency. (I know the Arduino code base has wildly inconsistent coding style and other ugliness. I try to keep my code somewhat consistent.)
cores/epoxy/Arduino.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| void noTone(uint8_t _pin) |
There was a problem hiding this comment.
nit: change this to
void noTone(uint8_t /*_pin*/) {}
kwisii
force-pushed
the
feature/tone_stubs
branch
from
5c062e8
to
d9f931b
Compare
|
You are right! |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added simple stubs for tone methods