Fix Client class definition #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I have made some minor corrections to the definition of the Client class.
The
virtual int read(uint8_t *buf, size_t size)method cannot be overridden because it does not exist in the Stream class.The Client class does not require an ESP core, as it is an abstract class that is part of the Arduino API. For example, it is possible to use it on AVR with the Ethernet library.
I have left the dependency on EPOXY_CORE_ESP8266 because in the IPAddress class it is indicated that way for the
rawIPAddress(IPAddress& addr)constant method, but I have corrected the syntax error that prevented compilation.I hope this helps.
Regards.