-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add #[Override] annotations and improve PHP 8.4 compatibility #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
byjg
wants to merge
7
commits into
master
Choose a base branch
from
5.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
48724ce
"Add #[Override] annotation and update compatibility and docs
byjg 3cc1caa
Add Gitpod configuration and migrate PHPUnit data providers
byjg dda89ba
Rename test classes for clarity and consistency.
byjg 14ef343
Refactor test class hierarchy and import structures.
byjg 2cd1be4
Refactor test class hierarchy and naming.
byjg 1529139
Test memcache isAvailable in GitHub Action
byjg e9f7137
Try Fix unit test
byjg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
tasks: | ||
- name: Run Composer | ||
command: | | ||
composer install | ||
|
||
image: byjg/gitpod-image:latest | ||
|
||
jetbrains: | ||
phpstorm: | ||
vmoptions: '-Xmx4g' | ||
plugins: | ||
- com.github.copilot | ||
- com.intellij.kubernetes | ||
- com.intellij.mermaid | ||
- ru.adelf.idea.dotenv | ||
- org.toml.lang | ||
|
||
vscode: | ||
extensions: | ||
- ikappas.composer | ||
- hbenl.test-adapter-converter | ||
- hbenl.vscode-test-explorer | ||
- felixfbecker.php-debug | ||
- neilbrayfield.php-docblocker | ||
- bmewburn.vscode-intelephense-client | ||
- getpsalm.psalm-vscode-plugin | ||
- SonarSource.sonarlint-vscode | ||
- recca0120.vscode-phpunit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"version": "0.2.0", | ||
"configurations": [ | ||
{ | ||
"name": "Debug current Script in Console", | ||
"type": "php", | ||
"request": "launch", | ||
"program": "${file}", | ||
"cwd": "${fileDirname}", | ||
"port": 9003, | ||
"runtimeArgs": [ | ||
"-dxdebug.start_with_request=yes" | ||
], | ||
"env": { | ||
"XDEBUG_MODE": "debug,develop", | ||
"XDEBUG_CONFIG": "client_port=${port}" | ||
} | ||
}, | ||
{ | ||
"name": "PHPUnit Debug", | ||
"type": "php", | ||
"request": "launch", | ||
"program": "${workspaceFolder}/vendor/bin/phpunit", | ||
"cwd": "${workspaceFolder}", | ||
"port": 9003, | ||
"runtimeArgs": [ | ||
"-dxdebug.start_with_request=yes" | ||
], | ||
"env": { | ||
"XDEBUG_MODE": "debug,develop", | ||
"XDEBUG_CONFIG": "client_port=${port}" | ||
} | ||
} | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposed Redis Credentials in Function Signature
Tell me more
What is the issue?
The Redis connection password parameter is passed directly through the function signature, potentially exposing sensitive credentials if used with hardcoded values.
Why this matters
Passing sensitive credentials through function parameters can lead to credentials being exposed in logs, stack traces, or debugging output. It also encourages developers to hardcode passwords in their code.
Suggested change ∙ Feature Preview
Consider accepting a configuration object or using dependency injection:
Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.