Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add on error to prevent errors of crashing observers #18

Merged
merged 6 commits into from
Jul 3, 2024
Merged

feat: add on error to prevent errors of crashing observers #18

merged 6 commits into from
Jul 3, 2024

Conversation

HilarioJrx
Copy link
Contributor

Was added a new method to handle errors while processing data into observers

byjg
byjg requested changes Jul 2, 2024
View reviewed changes
Copy link
Owner

@byjg byjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. I did some comments.

src/ORMSubject.php Outdated Show resolved Hide resolved
src/ObserverOnErrorData.php Outdated Show resolved Hide resolved
@HilarioJrx HilarioJrx requested a review from byjg July 3, 2024 14:47
@byjg byjg merged commit ccdc697 into byjg:master Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byjg byjg byjg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HilarioJrx @byjg