Add PublishCorrelated Request/Outgoing event to associate a Publish…
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message with an external id This simplifies associating a published message with the pkgid that it got assigned, without having to resort to event ordering.
de-sh
added
stale
mladedav
suggested changes
Mar 21, 2022
| @@ -152,6 +155,10 @@ pub enum Outgoing { | |||
| #[derive(Clone, Debug, PartialEq)] | |||
| pub enum Request { | |||
| Publish(Publish), | |||
| /// `PublishCorrelated` allows to correlate a `Publish` request with an id choosen by the | |||
There was a problem hiding this comment.
Suggested change
| /// `PublishCorrelated` allows to correlate a `Publish` request with an id choosen by the | |
| /// `PublishCorrelated` allows correlating a `Publish` request with an id chosen by the |
| @@ -152,6 +155,10 @@ pub enum Outgoing { | |||
| #[derive(Clone, Debug, PartialEq)] | |||
| pub enum Request { | |||
| Publish(Publish), | |||
| /// `PublishCorrelated` allows to correlate a `Publish` request with an id choosen by the | |||
| /// client. This serves the purpose to correlate a published message with the `pkgid` | |||
There was a problem hiding this comment.
Suggested change
| /// client. This serves the purpose to correlate a published message with the `pkgid` | |
| /// client. This serves the purpose to correlate a published message with the `pkid` |
|
In the new design #351 , we are returning pkid from publishes. That should help with correlating outgoing messages and incoming acks. Closing this now. Please feel free to reopen this if you have more questions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… message with an external id
This simplifies associating a published message with the pkgid that it
got assigned, without having to resort to event ordering.