Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for MQTT 3.1 #395

Closed
wants to merge 1 commit into from
Closed

Conversation

Freax13
Copy link

@Freax13 Freax13 commented May 13, 2022

This pr adds support for MQTT 3.1 to rumqttc.

This pr is based on https://www.oasis-open.org/committees/download.php/55095/mqtt-diffs-v1.0-wd01.doc.

This pr introduces a breaking change:

pub fn new<S: Into<String>>(protocol: Protocol, id: S) -> Connect {

@ColinFinck ColinFinck mentioned this pull request May 16, 2022
Closed
@de-sh de-sh requested a review from tekjar May 19, 2022 04:41
@Freax13
Copy link
Author

Freax13 commented May 20, 2022

The failed CI job seems unrelated to this pr.

@de-sh
Copy link
Contributor

de-sh commented Jun 6, 2022

Hey @Freax13, had a discussion about this PR with @tekjar. We are currently blocked on adding MQTT 5 support, so we are not very sure about how we could maintain support for 3.1 going ahead. We are curious about where and why you continue using it, instead of 3.1.1 or 5.

@Freax13
Copy link
Author

Freax13 commented Jun 10, 2022

We are curious about where and why you continue using it, instead of 3.1.1 or 5.

We don't have a choice, we don't control the broker/server we're connecting to.

@de-sh
Copy link
Contributor

de-sh commented Jun 27, 2022

@Freax13 we are sorry, but the added cost of maintaining this is not something we are ready to take up atm.

@de-sh de-sh closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants