[cap-primitives] add support for illumos #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the cap-primitives library building and passing all tests on illumos. There were just a couple of minor tweaks required. I also ran into an issue where the minimum version of `ipnet` required was too old, so I took the liberty to bump it to 2.5.0 which has `IpNet::new`. The note in `dir_entry.rs` is copied over from Rust's std: https://doc.rust-lang.org/std/fs/struct.DirEntry.html#method.file_type
sunshowers
commented
Oct 29, 2024
| &["/dev/ttyv0", "/dev/pts/0"] | ||
| } else if cfg!(target_os = "illumos") { |
There was a problem hiding this comment.
I wasn't sure about Solaris here so I left this as illumos. The other bits I'm reasonably sure are okay on Solaris.
22 tasks
|
Looks good, thanks! |
|
This is now released in cap-std 3.4.0. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the cap-primitives library building and passing all tests on illumos. There were just a couple of minor tweaks required.
I also ran into an issue where the minimum version of
ipnetrequired was too old, so I took the liberty to bump it to 2.5.0 which hasIpNet::new.The note in
dir_entry.rsis copied over from Rust's std: https://doc.rust-lang.org/std/fs/struct.DirEntry.html#method.file_type