-
Notifications
You must be signed in to change notification settings - Fork 62
Consider reverting --reactor
to --lib
#198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This distinction goes back to the idea of reactors vs commands going back to here or potentially earlier. |
In addition to aligning with component model terms, the intention behind the change was to make a distinction between a "normal" Rust However, If there's general consensus that |
I am also in favor of the |
I forgot about this but seeing it bumped into my notifs now, and having sat with this for a little while I'm also in favor of changing it to Understanding that a cargo component lib means component model reactor is something easy enough to learn later on if they become more sophisticated users, and using |
This commit renames the `--reactor` option for the `new` subcommand to `--lib`. It maintains an alias of `--reactor` for backwards compatibility. Updated the tests to use `--lib` and added a test to ensure `--reactor` is still respected. Closes bytecodealliance#198.
This commit renames the `--reactor` option for the `new` subcommand to `--lib`. It maintains an alias of `--reactor` for backwards compatibility. Updated the tests to use `--lib` and added a test to ensure `--reactor` is still respected. Closes #198.
Uh oh!
There was an error while loading. Please reload this page.
It seems as part of the large refactor in #101 the
--lib
flag was also renamed to--reactor
. What's the reason for this change?The term "reactor" suggests a component can somehow "react"? The term is commonly associated with reactive programming but it seems that's not what it should mean here.
The README admits the need to explain it means a library.
It somewhat makes sense if calling the component's exported functions makes it "react". But in that sense, a command component similarly "reacts" to its
run
function being called.Is there a strong reason to replace the existing term "library" that's widely used across languages and ecosystems with a new term "reactor" which might be confused with an unrelated meaning? Why not call a library a library?
The text was updated successfully, but these errors were encountered: