Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wasm-wasip2 target as default build target #355

Open
ifsheldon opened this issue Nov 19, 2024 · 4 comments
Open

Use wasm-wasip2 target as default build target #355

ifsheldon opened this issue Nov 19, 2024 · 4 comments

Comments

@ifsheldon
Copy link

When the Rust compiler supports a [_preview2_ version of the WASI target][1],

Hi! I saw this today, but the referred issue has been closed as complete. The latest cargo-component 0.19 still uses wasm-wasip1 as the default build target.

Rust in the latest stable 1.82 has promoted wasm-wasip2 as a tier-2 target, see rust-lang/rust#129997. I think it's time to change the README and the behavior of cargo-component?

@pchickey
Copy link

Related: #356

@sunfishcode
Copy link
Member

Yes. The current situation is, the wasm32-wasip2 target does a lot of things automatically, which is great and makes it easy to drop into existing Rust development workflows. But, it also doesn't support all the features of cargo component. I looked into it briefly, and didn't see anything supporting import name maps. So there's more to figure out here before we can switch cargo component to using wasm32-wasip2 internally.

sunfishcode added a commit that referenced this issue Nov 27, 2024
Update the documentation talking about Rust's wasm32-wasip2 feature. We
do hope to make use of it in `cargo component`, though it's not a trivial
change.

This is inspired by #355.
@sunfishcode
Copy link
Member

I've also now posted #359 to update the README text quoted above.

@ifsheldon
Copy link
Author

OK, thanks. I am not super familiar with cargo-component.

I think this issue can be turned into a tracker if you can list missing features on the wasm32-wasip2 target.

sunfishcode added a commit that referenced this issue Dec 3, 2024
Update the documentation talking about Rust's wasm32-wasip2 feature. We
do hope to make use of it in `cargo component`, though it's not a trivial
change.

This is inspired by #355.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants