upgrade wasmtime and wasmtime cli options #78
Conversation
bytecodealliance/wasmtime#6925 modified the command line options of `wasmtime`. The `--wasm-features` option for `wasmtime run` has been changed to `--wasm`.
| @@ -46,6 +46,6 @@ wasm-tools compose command/target/wasm32-wasi/release/command.wasm -d composed.w | |||
| Now, run the component with wasmtime: | |||
|
|
|||
| ```sh | |||
| wasmtime run --wasm-features component-model command.wasm 1 2 add | |||
| wasmtime run --wasm component-model command.wasm 1 2 add | |||
There was a problem hiding this comment.
I just downloaded the latest wasmtime 13.0.0 and I am not seeing the --wasm flag, only the preexisting --wasm-features flag
There was a problem hiding this comment.
Hello, thank you for your review. You're correct, bytecodealliance/wasmtime#6925 was not included in the wasmtime v13.0.0 release, and I apologize for not verifying it in advance.
According to the wasmtime release process documentation, it will be included in the v14.0.0 release scheduled for October 20th. Do you think we should update the wasmtime version to the latest commit on the main branch, or should we wait until v14.0.0 is released before submitting the PR?
There was a problem hiding this comment.
Hi! We do call out in our docs to use latest dev, so this is flag applicable to that. Maybe we hold off the wasmtime cli changes till v14.0.0 is released, but update our docs that now you can use the wasmtime v13 release? We could still update the commit of the example-host as you have it to point to v13.0.0. I found that change was needed for the latest go toolchain: https://github.com/bytecodealliance/component-docs/pull/77/files#diff-d57d0b804e54f1a62d48be7c4af65e39543d8635b92e2837be5d1bc51a166969.
There was a problem hiding this comment.
I noticed that #77 also includes a commit to update wasmtime to v13.0.0. I think I will go ahead and close this PR, and after wasmtime v14.0.0 is released, I will submit a new PR.
bytecodealliance/wasmtime#6925 modified the command line options of
wasmtime. The--wasm-featuresoption forwasmtime runhas been changed to--wasm.