Extract the runner module into its own crate
#678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcharles
approved these changes
Jul 2, 2024
| self | ||
| } | ||
|
|
||
| pub fn wit(&mut self, wit: impl Into<PathBuf>) -> &mut Self { |
There was a problem hiding this comment.
Arguably wit and world could be one function given they either both need to be provided or neither should be provided but this is fine
This commit extracts the utiility runner module, used in the integration tests into its own private crate. The main motivation for this change is to enable sharing this functionality between integration tests and the upcoming `javy-fuzz` crate. Additionally, this change promotes some dependencies to the workspace level, namely: - `tempfile` - `uuid`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extracts the utiility runner module, used in the integration tests into its own private crate.
The main motivation for this change is to enable sharing this functionality between integration tests and the upcoming
javy-fuzzcrate.Additionally, this change promotes some dependencies to the workspace level, namely:
tempfileuuidChecklist
javy-cliandjavy-coredo not require updating CHANGELOG files.