Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Removing deprecated crates from the workspace, the fmt checks for deprecated crates from the makefile, and a few updates to appease the new version of Clippy:
&mut store
tostore.as_mut_context()
Why am I making this change?
CI always uses the latest stable version of Clippy and that version of Clippy introduced new checks which our code fails. I adjusted the workspace and the
Makefile
since I don't want to make changes to the deprecatedquickjs-wasm-sys
orquickjs-wasm-rs
crates but still want to be able to runmake fmt
to see all failing Clippy checks that would show up in CI.For the
&mut store
tostore.as_mut_context()
changes, Clippy seems to sometimes get confused when passing&mut store
to a Wasmtime method that takesstore: impl AsContextMut
and states we should only passstore
. Unfortunately the Rust compiler obviously complains when passingstore
without the&mut
ifstore
is referenced again later because Rust will treat it as a move. At first I wrote I just updated call sites where Clippy complained but then it looks inconsistent within a function or file where sometimes we're passingstore.as_context_mut()
and sometimes we're passing&mut store
and it's not obvious why we're using the first in some places and the second in others. So, I decided to make passing stores consistent since the behaviour is identical anyway.Checklist
javy-cli
andjavy-core
do not require updating CHANGELOG files.