Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using javy-cli in javy tests #725

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Stop using javy-cli in javy tests #725

merged 1 commit into from
Aug 14, 2024

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Stop using javy-cli NPM package in javy NPM package tests.

Why am I making this change?

The javy-cli NPM package is deprecated so we should stop using it.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles marked this pull request as ready for review August 14, 2024 19:33
@jeffcharles jeffcharles mentioned this pull request Aug 14, 2024
Merged
3 tasks
@jeffcharles jeffcharles merged commit 6fa604d into main Aug 14, 2024
16 checks passed
@jeffcharles jeffcharles deleted the jc.update-javy-npm-package-tests branch August 14, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffcharles @saulecabrera