Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clean target from Makefile #738

Merged

Conversation

saulecabrera
Copy link
Member

This commit removes the clean target from the Makefile:

  • We no longer have to deal with downloading wasi-sdk
  • Given (1), we can simply call cargo clean if we want to clean cargo artifacts.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

This commit removes the `clean` target from the `Makefile`:

* We no longer have to deal with downloading `wasi-sdk`
* Given (1), we can simply call `cargo clean` if we want to clean cargo
  artifacts.
@saulecabrera saulecabrera merged commit cc14d0e into bytecodealliance:main Aug 27, 2024
7 checks passed
@saulecabrera saulecabrera deleted the remove-clean-wasi-sdk-target branch August 27, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants