Derive runtime config defaults from javy_config::Config #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Centralizes the default JS runtime configuration in the
javy_config::Config
struct'sDefault
implementation. This will also keep the JS runtime command line settings default values in sync with thejavy_config::Config
default values.Why am I making this change?
Prior there were a few different places in the code that would set configuration properties to different values depending on the path through the code (e.g., some used
Config::all
, others disabledOVERRIDE_JSON_PARSE_AND_STRINGIFY
).Checklist
javy-cli
andjavy-core
do not require updating CHANGELOG files.