Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive runtime config defaults from javy_config::Config #741

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Centralizes the default JS runtime configuration in the javy_config::Config struct's Default implementation. This will also keep the JS runtime command line settings default values in sync with the javy_config::Config default values.

Why am I making this change?

Prior there were a few different places in the code that would set configuration properties to different values depending on the path through the code (e.g., some used Config::all, others disabled OVERRIDE_JSON_PARSE_AND_STRINGIFY).

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles merged commit 40b53ca into main Aug 30, 2024
7 checks passed
@jeffcharles jeffcharles deleted the jc.move-runtime-defaults-to-config branch August 30, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants