This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
implement wasi-filesystem::readdir and related functions
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `directory_list` test and provides the required host implementation. I've also added a file length check to the `file_read` test, just to cover a bit more of the API. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
|
Hmm... tests are passing with |
We were copying `name.len() * 256` bytes instead of just `name.len()` bytes, which was overwriting other parts of `State` and causing untold havoc. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
|
Ah, debugging memory corruption without a debugger -- just like the good old days of C++ on weird platforms. At least it was deterministic this time. |
sunfishcode
reviewed
Jan 4, 2023
| name.as_ptr().cast(), | ||
| (*state.dirent_cache.path_data.get()).as_mut_ptr(), | ||
| name.as_ptr().cast::<u8>(), | ||
| (*state.dirent_cache.path_data.get()).as_mut_ptr() as *mut u8, |
There was a problem hiding this comment.
Can this use .cast instead of as?
There was a problem hiding this comment.
cast yields a *const T, not a *mut T. I tried using a combination of cast and cast_mut, but the compiler claims it can't find the latter method at all even though I seem to be using a recent enough version of Rust. 🤷
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
directory_listtest and provides the required host implementation.I've also added a file length check to the
file_readtest, just to cover a bit more of the API.Signed-off-by: Joel Dice joel.dice@fermyon.com