This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
Bugfix and API adjustment for reference types support. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfallin
force-pushed
the
reftypes
branch
3 times, most recently
from
9fdfa16
to
5a87f58
Compare
cfallin
changed the title
julian-seward1
approved these changes
Jul 2, 2020
This comment changes the reftypes analysis that computes "reffyness" of each virtual/live range: it only propagates reffyness precisely, to specific ranges, not to all ranges associated with a register.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in the reference-type support from #80, and makes a minor API adjustment.
In particular, this bugfix ensures that the "reffyness" computation is as precise as we need it to be (by propagating reffyness only to specific ranges associated with registers, rather than all of them, since e.g. a given rreg might be reffy at one program-point but not another).
Tested by integrating into Cranelift (PR over there will be created once this lands) and then into SpiderMonkey from there (patch also pending).
I'll plan to add checker support to verify stackmaps so that we can fuzz this and have a bit more confidence in it.