Add some comments and minor cleanups #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qualify `Arg` as `path::Arg`, and reorder `execve` to come before `_execve`, for consistency with patterns used elsewhere in the codebase.
sunfishcode
force-pushed
the
sunfishcode/comments
branch
from
f7a9b13 to
8a49a87
Compare
sunfishcode
force-pushed
the
sunfishcode/comments
branch
from
8fe7dec to
3d82f69
Compare
This also works on Windows, and it shows off the use of bitflags values in place of raw integer flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more comments to
forkexplaining safety conditions, and includes a few additional minor cleanups.