Detect when statx isn't available on older versions of Docker.
#357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older versions of Docker, `statx` can fail with `EPERM` meaning it isn't available. Recognize this, and translate it into `ENOSYS`. Also, have `statx` remember this and fail quickly in future calls. This is more emulation than rustix usually likes to do, but in this case, this is the behavior seems likely to be what most users will want, and we might as well put the code in one place. Fixes #352.
sunfishcode
force-pushed
the
sunfishcode/is-statx-available
branch
from
860d7a0 to
19832e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of Docker,
statxcan fail withEPERMmeaning itisn't available. Recognize this, and translate it into
ENOSYS. Also,have
statxremember this and fail quickly in future calls.This is more emulation than rustix usually likes to do, but in this
case, this is the behavior seems likely to be what most users will
want, and we might as well put the code in one place.
Fixes #352.