-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD RESOLVE_BENEATH support and more #541
Conversation
bfe0476
to
fd6b726
Compare
752d5a1
to
bd17a8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cc @notgull in case you're interested in the kqueue changes.
For chmodat, it feels like it might be error-prone to have the flag on Linux where it isn't supported. What would you think about adding a chmodat_with function with a flags argument, that's only available on platforms that support flags?
Hm, that can be done for not breaking backwards compatibility I guess. |
Good point, having it fail with The other concern here is that rustix recently had a semver bump with 0.37, and we hopefully won't need another for quite a while. Would you be ok introducing a different name for now, with a plan to change it once we start thinking about the next semver bump? |
4e02ec2
to
475c013
Compare
Nah, Fun discovery btw: musl implements Changed to |
a4ba539
to
58c2523
Compare
This looks good! I made a note about the naming of |
Yaay :3 I'll have a little bit more coming today (adding more procctl's right now), hopefully it'd be possible to get that into the next minor release |
This is everything required to implement support for FreeBSD's
(O|AT)_RESOLVE_BENEATH
based lookup sandboxing in cap-std :) While here, also expose more Linux-compatible stuff that FreeBSD's libc exposes, also improve kqueue a bit.The
chmodat
signature change is an API break :/ but the omission offlags
feels like a mistake to me and I think it's better to fix it earlier rather than later. What do you think?Waiting for: a libc release with rust-lang/libc#3114 rust-lang/libc#3122 rust-lang/libc#3124wheeeeIncludes: #540