Factor out a new top-level mount module.
#763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/mount-api
branch
from
c7c4362 to
58d17fb
Compare
6 tasks
Create `rustix::mount`, and move the mount-related and fsopen-related functions into it, adding deprecated aliases in `rustix::fs` for compatibility. This also renames several functions which are all specialized forms of the `mount` system call, so I renamed them to have `mount` at the beginning. It also fixes the collision with the real `move_mount` system call. - `remount` to `mount_remount` - `bind_mount` to `mount_bind` - `recursive_bind_mount` to `mount_recursive_bind` - `change_mount` to `mount_change` - `move_mount` to `mount_move` And, it adds documentation links to a [new repository] I set up to host formatted versions of the draft manual pages that were posted. [new repository]: https://github.com/sunfishcode/linux-mount-api-documentation
sunfishcode
force-pushed
the
sunfishcode/mount-api
branch
from
05420f2 to
54ff6cc
Compare
|
Small nit: since we're renaming things, I wonder if Looks great otherwise! (Based on the PR description, won't have time to look at code) |
|
Thanks! The documentation calls it a "recursive bind mount" so the answer to "what kind of mount is it?" is "a recursive bind one", so I went with |
|
Sounds good! |
sunfishcode
added a commit
that referenced
this pull request
Jan 22, 2025
See [this comment] for details. [this comment]: #763 (comment)
sunfishcode
added a commit
that referenced
this pull request
Jan 22, 2025
See [this comment] for details. [this comment]: #763 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
rustix::mount, and move the mount-related and fsopen-related functions into it, adding deprecated aliases inrustix::fsfor compatibility.This also renames several functions which are all specialized forms of the
mountsystem call, so I renamed them to havemountat the beginning. It also fixes the collision with the realmove_mountsystem call.remounttomount_remountbind_mounttomount_bindrecursive_bind_mounttomount_recursive_bindchange_mounttomount_changemove_mounttomount_moveAnd, it adds documentation links to a new repository I set up to host formatted versions of the draft manual pages that were posted.
@yujincheng08 @SUPERCILEX