Add simd.suite
#268
Merged
Add simd.suite
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in a Cranelift meeting, it would be nice to know which benchmarks are SIMD users. This change adds a `simd.suite` file that lists the files that contain SIMD instructions. This can be run like: ```console $ cargo run -- benchmark --engine .../libengine.so benchmarks/simd.suite ``` There are a couple ways this could be improved, but this may be fine as-is for now: - `simd.suite` could get out of date; someone could create a CI check to keep it in-sync with the added files - someone could really check that the measured section of each benchmark is actually a heavy SIMD user by collecting the instruction mix (e.g., `sde`)
|
cc: @alexcrichton, @fitzgen, @jameysharp, @cfallin |
fitzgen
approved these changes
Aug 30, 2023
|
I'm going to merge this in hopes that recent Wasmtime changes have fixed the build issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in a Cranelift meeting, it would be nice to know which benchmarks are SIMD users. This change adds a
simd.suitefile that lists the files that contain SIMD instructions. This can be run like:$ cargo run -- benchmark --engine .../libengine.so benchmarks/simd.suiteThere are a couple ways this could be improved, but this may be fine as-is for now:
simd.suitecould get out of date; someone could create a CI check to keep it in-sync with the added filessde)