Add ubsan checks to WAMR #2147
Merged
Add ubsan checks to WAMR #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
loganek
reviewed
Apr 25, 2023
loganek
reviewed
Apr 25, 2023
| endif() | ||
|
|
||
| if (SANITIZER STREQUAL "ubsan") | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -O2 -fno-omit-frame-pointer -fsanitize=undefined -fno-sanitize-recover=all -fno-sanitize=alignment" ) |
There was a problem hiding this comment.
Do we also need to check for a compiler here, or are we ok with the compiler (sliently) failing if those flags are not supported?
There was a problem hiding this comment.
I believe that you won't set these flags for the wrong compiler on the CI side.
But if you think it's better to add here I'll add
Zzzabiyaka
force-pushed
the
main
branch
7 times, most recently
from
cc39430
to
100d9ae
Compare
loganek
reviewed
Apr 25, 2023
| @@ -87,6 +87,15 @@ endif() | |||
| set(WAMR_ROOT_DIR ${CMAKE_CURRENT_LIST_DIR}/../..) | |||
| include (${WAMR_ROOT_DIR}/build-scripts/runtime_lib.cmake) | |||
|
|
|||
| if (NOT DEFINED SANITIZER) | |||
| set(SANITIZER "") | |||
There was a problem hiding this comment.
is that variable going to be used outside of this if..else block that we set it here?
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
This PR adds ubsan checks with no alignment enabled to basic CI tests for samples/wasm-c-api. Co-authored-by: Maksim Litskevich <makslit@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds ubsan checks with no aligment enabled to basic CI tests.