-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debugger extension tests #2292
Add debugger extension tests #2292
Conversation
527b16d
to
a7cf180
Compare
c54891f
to
f5741d0
Compare
f5741d0
to
39b31d4
Compare
@@ -565,3 +568,117 @@ jobs: | |||
if: env.TEST_ON_X86_32 == 'true' | |||
run: ./test_wamr.sh ${{ env.X86_32_TARGET_TEST_OPTIONS }} ${{ matrix.test_option }} -t ${{ matrix.running_mode }} | |||
working-directory: ./tests/wamr-test-suites | |||
|
|||
test-wamr-ide: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add it to nightly_run instead of per-PR if it's 2hrs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LLDB version doesn't get updated that often, if we cache it (the first time a PR for the update is created), it should be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it should be fine.
The LLDB patch file was changed four times in the last 2 years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you got it
To run tests locally, the node version has to be 16.x+(GitHub Actions use 18.16.0), is there a way to add it in What I can think of is to add the engines field in your "engines": {
"vscode": "^1.59.0",
"node": "^16.0.0"
}, and add engine-strict option in the new engine-strict=true This will force npm to err for node versions lower than 16.x. I think it's better to err by setting What do you think? Is there any other way to achieve this? |
f7d943a
to
4e1469e
Compare
Hi @TianlongLiang, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
does it worth adding the same tests for macOS CI job if it's supported? @MrSarius |
In general, of course, the integration tests could also find major problems in the LLDB build (crashes etc.). That could be helpful for all platforms that are suppported. But in the context of the extension, that doesn't add much value compared to the extra effort it means (building and caching LLDB for Macos) |
Since building the extension now depends on node >=16 (see #2292), build_wamr_vscode_ext.yml will fail on the next release without this change.
Hi, @MrSarius, after the recent update of VS Code, for version above 1.86.0, it seems that the format conversion in
For fixing the CI error, could you please let me know your opinion? Do you think this is mainly a VS Code bug? If so, maybe we can safely ignore it for a while and use the fixed VS Code version. Or is it a major interface change that needs modification on our side? |
This PR adds tests for bytecodealliance#2219 by changing the `compilation_on_android_ubuntu.yml` workflow. The first run will take about two hours, since LLDB is built from scratch. Later, the build is cached and the whole job should not take more than three minutes. Core of the PR is an integration test that boots up vscode and lets it debug a test WASM file.
Since building the extension now depends on node >=16 (see bytecodealliance#2292), build_wamr_vscode_ext.yml will fail on the next release without this change.
This PR adds tests for #2219. The VS Code extension has not had any tests yet. The tests only cover code that was touched by me.
I have added the tests to the
compilation_on_android_ubuntu.yml
workflow. The first run will take about two hours, since LLDB is built from scratch. Later, the build should be cached and the whole job should not take more than three minutes.Core of the PR is an integration test that boots up vs code and lets it debug a test WASM file.
Run Tests locally
Download the LLDB build for your platform from my pipeline.
Make sure wasm32-wasi target is available.
Build iwasm with source debugging feature
Install npm dependencies and run tests.