-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasi-nn: simplify cmake and headers location #2308
Merged
wenyongh
merged 6 commits into
bytecodealliance:main
from
midokura:tbc/reorder-cmake-headers
Jun 26, 2023
Merged
wasi-nn: simplify cmake and headers location #2308
wenyongh
merged 6 commits into
bytecodealliance:main
from
midokura:tbc/reorder-cmake-headers
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ayakoakasaka please review! |
tonibofarull
force-pushed
the
tbc/reorder-cmake-headers
branch
from
June 24, 2023 12:44
d86889a
to
af93d06
Compare
tonibofarull
force-pushed
the
tbc/reorder-cmake-headers
branch
from
June 24, 2023 21:16
55af2f4
to
ba1feda
Compare
wenyongh
reviewed
Jun 25, 2023
wenyongh
reviewed
Jun 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Major changes: - Public headers inside `wasi-nn/include` - Put cmake files in `cmake` folder - Make linux iwasm link with `${WASI_NN_LIBS}` so iwasm can enable wasi-nn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
wasi-nn/include
.cmake
.linux
iwasm contains${TENSORFLOW_LIB}
. iwasm can enable wasi-nn.