Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix result arity check on select_t opcode #2406

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix result arity check on select_t opcode #2406

merged 2 commits into from
Jul 31, 2023

Conversation

wenyongh
Copy link
Contributor

Typed select must have exactly one result. Reported in issue #2402.

@wenyongh wenyongh mentioned this pull request Jul 31, 2023
Open
yamt
yamt reviewed Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasm_mini_loader.c seems to have the same issue.

@wenyongh
Copy link
Contributor Author

wasm_mini_loader.c seems to have the same issue.

Thanks, done.

yamt
yamt approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wenyongh wenyongh merged commit edea32b into bytecodealliance:main Jul 31, 2023
368 checks passed
@wenyongh wenyongh deleted the fix_select_t branch August 1, 2023 11:15
Zzzabiyaka pushed a commit to Zzzabiyaka/wasm-micro-runtime that referenced this pull request Aug 1, 2023
@wenyongh @Zzzabiyaka
Fix result arity check on select_t opcode (bytecodealliance#2406)
059960e 
Typed select must have exactly one result. Reported in issue bytecodealliance#2402.
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@wenyongh
Fix result arity check on select_t opcode (bytecodealliance#2406)
4b862fc 
Typed select must have exactly one result. Reported in issue bytecodealliance#2402.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamt yamt yamt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenyongh @yamt