Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add another wamr test #2411

Merged
merged 1 commit into from
Aug 17, 2023
Merged

add another wamr test #2411

merged 1 commit into from
Aug 17, 2023

Conversation

Zzzabiyaka
Copy link
Contributor

@Zzzabiyaka Zzzabiyaka commented Jul 31, 2023 •
edited
Loading

follows up #2364 where we discussed that we might want to have a test which has really short thread function and creates many threads

@Zzzabiyaka Zzzabiyaka changed the title Makslit/add another wamr test add another wamr test Jul 31, 2023
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch 17 times, most recently from e098ec6 to ecc7977 Compare August 4, 2023 11:35
@Zzzabiyaka Zzzabiyaka marked this pull request as ready for review August 4, 2023 11:58
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch 4 times, most recently from 245354c to 2d902ee Compare August 8, 2023 18:31
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch 3 times, most recently from a316ac9 to ae6d3f7 Compare August 9, 2023 11:45
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch 3 times, most recently from 85c0318 to eb6f1d7 Compare August 9, 2023 23:25
This was referenced Aug 11, 2023
Closed
Merged
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch 6 times, most recently from ffa6929 to 3c25306 Compare August 15, 2023 15:50
wenyongh
wenyongh approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzzabiyaka @loganek Is it OK merge this PR now?

@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch from 3c25306 to 379788c Compare August 16, 2023 10:26
@Zzzabiyaka
Copy link
Contributor Author

I think it is but let's wait on @loganek a bit

from my point of view that's fine

@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch 3 times, most recently from 5c2a3db to 0acb998 Compare August 16, 2023 12:58
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch from 0acb998 to d24a4f3 Compare August 16, 2023 21:30
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/add_another_wamr_test branch from d24a4f3 to f3d542c Compare August 16, 2023 21:31
@wenyongh wenyongh merged commit 4ce675a into bytecodealliance:main Aug 17, 2023
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@Zzzabiyaka
Add another wamr test (bytecodealliance#2411)
9efc05c 
Follows up bytecodealliance#2364 where we discussed that we might want to have a test
which has really short thread function and creates many threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganek loganek loganek approved these changes

@wenyongh wenyongh wenyongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zzzabiyaka @loganek @wenyongh