Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in test_wamr.sh #2421

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

Zzzabiyaka
Copy link
Contributor

@Zzzabiyaka Zzzabiyaka commented Aug 3, 2023

I will close this PR if it is done on purpose.

Another question: can I split "jit" test type to "eager_jit" and "lazy_jit" so that the ci is more consistent (e.g. one test type would always mean that test bundle will run once. It's already true right now with jit being the only exception)

@wenyongh wenyongh merged commit 29761c7 into bytecodealliance:main Aug 4, 2023
@wenyongh
Copy link
Contributor

wenyongh commented Aug 4, 2023

I will close this PR if it is done on purpose.

Another question: can I split "jit" test type to "eager_jit" and "lazy_jit" so that the ci is more consistent (e.g. one test type would always mean that test bundle will run once. It's already true right now with jit being the only exception)

@Zzzabiyaka Thanks for fixing, it is really an issue! For the new jit options, how about adding "llvm-lazy-jit" and "llvm-eager-jit" options to make it more clear? Using "-" other than "_" is because we already have "fast-interp"/"classic-interp"/"fast-jit".
And had better just keep current "jit" option which tests both "llvm-lazy-jit" and "llvm-eager-jit", as it is used in some other scripts and it is also an shortcut to test two llvm jit modes.

@Zzzabiyaka
Copy link
Contributor Author

Hi, ok, shouldn't be a problem.

I will just set a different (2x more) timeout for jit in the ci

@Zzzabiyaka Zzzabiyaka deleted the makslit/fix_test_typo branch August 16, 2023 19:51
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Change `ORC_EAGER_JIT_COMPILE_FLAGS` to `ORC_LAZY_JIT_COMPILE_FLAGS`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants