iwasm: fix native lib cleanup after error #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if something failed after calling init_native_lib, call deinit_native_lib to clean up. * restructure the relevant code for better maintainability.
wenyongh
reviewed
Aug 10, 2023
product-mini/platforms/posix/main.c
Outdated
| struct native_lib * | ||
| load_native_lib(const char *name) | ||
| { | ||
| struct native_lib *lib = malloc(sizeof(*lib)); |
There was a problem hiding this comment.
How about using wasm_runtime_malloc/wasm_runtime_free to be consistent with other places?
There was a problem hiding this comment.
it makes sense. i will change.
wenyongh
reviewed
Aug 10, 2023
product-mini/platforms/posix/main.c
Outdated
| } | ||
| free(lib); |
There was a problem hiding this comment.
Should use wasm_runtime_free.
There was a problem hiding this comment.
oops. fixed. thank you.
yamt
force-pushed
the
native-lib-deinit
branch
from
bf05525
to
61eac4f
Compare
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
- If something failed after calling init_native_lib, call deinit_native_lib to clean up. - Restructure the relevant code for better maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if something failed after calling init_native_lib, call deinit_native_lib to clean up.
restructure the relevant code for better maintainability.