-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run rust tests from wasi-testsuite #2484
Conversation
Currently can't merge this due to a failing test on android, ubuntu 22.04: I can reproduce it locally on OSX but I'm not completely sure I understand if the test is correct. Also the following rust tests are failing on nightly (can't reproduce locally): interesting_paths Will need to investigate more to figure out why these are failing. |
Please see the related conversation in WebAssembly/wasi-testsuite#59. Depending on the result of that, we'll either delete the test or update the specification (and WAMR implementation accordingly). |
d09065a
to
9b8f617
Compare
70dd8af
to
2e43ac4
Compare
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
I've raised a PR in wasi-testsuite to fix the tests which had various permissions issues etc. |
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
3805022
to
a3dd180
Compare
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
a3dd180
to
bcbfad9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
posix.c change seems too big to sneak within a "Run rust tests from wasi-testsuite" PR.
i'd suggest to make it a separate PR.
bcbfad9
to
68e7b7f
Compare
Since some of the tests have changed the expected behavior (e.g. the
for the After those are merged and this PR is rebased, it should be green and good to merge. |
68e7b7f
to
7fced97
Compare
failing wasi-threads tests should pass if you rebase. cf. #2568 |
7fced97
to
6729729
Compare
@wenyongh would you mind taking another look? Build is green now so should be good to merge, thanks very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Run rust tests from wasi-testsuite (bytecodealliance#2484)
No description provided.