Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to avoid the stack traces getting mixed up together when using multiple threads. This is achieved by using
exception_lock(module_inst)
.I also noticed that, when an exception occurs, the output is a bit confusing since every thread would report the exception and then
iwasm
reports it one additional time at the end. I think it makes sense to remove the error prints from each thread and report the exception only once at the end (after all threads have finished).Before:
After: