Implement aot_alloc_frame/aot_free_frame with LLVM IRs #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge bytecodealliance:dev/gc_refactor into wenyongh:dev/refine_aot_alloc_frame
Disable ems memory allocator heap corruption check when GC is enabled (bytecodealliance#2838)
wenyongh
changed the title
| #endif | ||
|
|
||
| #if WASM_ENABLE_MEMORY_PROFILING != 0 | ||
| if (alloc_frame) { |
There was a problem hiding this comment.
Seems alloc_frame means start of the function, is it correct to measure stack use at the start of the function rather than end of the function?
There was a problem hiding this comment.
Here it does the same thing in aot_alloc_frame, which calls wasm_exec_env_alloc_wasm_frame, and wasm_exec_env_alloc_wasm_frame sets exec_env->max_wasm_stack_used if needed:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.