Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit SIMD flags to AOT file if SIMD actually used #2911

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Emit SIMD flags to AOT file if SIMD actually used #2911

merged 1 commit into from
Dec 25, 2023

Conversation

no1wudi
Copy link
Collaborator

@no1wudi no1wudi commented Dec 19, 2023

No description provided.

@no1wudi no1wudi force-pushed the dev/gc_refactor branch 2 times, most recently from 820fa6d to f6892e0 Compare December 19, 2023 07:21
wenyongh
wenyongh reviewed Dec 20, 2023
View reviewed changes
core/iwasm/interpreter/wasm.h Outdated Show resolved Hide resolved
core/iwasm/interpreter/wasm_loader.c Show resolved Hide resolved
wamr-compiler/main.c Outdated
}
else {
option.enable_simd = false;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to set the flag inside aot_create_comp_data? The wasm_module is passed into the function.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that, handle it in aot_create_comp_context seems better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe it is better to handle it in aot_create_comp_context.

@no1wudi no1wudi force-pushed the dev/gc_refactor branch 2 times, most recently from 27d14b6 to 219d1f2 Compare December 20, 2023 07:59
wenyongh
wenyongh reviewed Dec 25, 2023
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 7de3170 into bytecodealliance:dev/gc_refactor Dec 25, 2023
397 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no1wudi @wenyongh